Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix AR tests and execd library. #4511

Merged
merged 2 commits into from
Sep 15, 2023
Merged

Fix AR tests and execd library. #4511

merged 2 commits into from
Sep 15, 2023

Conversation

mauromalara
Copy link
Contributor

@mauromalara mauromalara commented Sep 11, 2023 •
edited by Deblintrake09
Loading

Related issue
#4512

Description

An error was introduced in this PR and we did not detect it because we did not execute the tests with the applied changes in Windows, This led to a bug, breaking the tests on that system.

Updated

  • CHANGELOG.md
  • deps/wazuh_testing/wazuh_testing/execd.py
  • tests/integration/test_active_response/test_execd/test_execd_restart.py

Testing performed

Tester Test path Jenkins Local OS Commit Notes
@user (Developer) 🟢 🟢 🟢 🚫🚫🚫 CentOS/Windows Nothing to highlight
@Deblintrake09 (Reviewer) 🟢🟢🟢 🚫🚫🚫 CentOS/Windows Nothing to highlight

@mauromalara mauromalara self-assigned this Sep 11, 2023
@mauromalara mauromalara linked an issue Sep 12, 2023 that may be closed by this pull request
Active response IP was not added to iptable #4336
Closed
2 tasks
@rauldpm rauldpm linked an issue Sep 12, 2023 that may be closed by this pull request
Timeout in Active Response integration test #4512
Closed
@rauldpm rauldpm removed a link to an issue Sep 12, 2023
Active response IP was not added to iptable #4336
Closed
2 tasks
@mauromalara mauromalara mentioned this pull request Sep 12, 2023
Closed
2 tasks
@juliamagan juliamagan mentioned this pull request Sep 14, 2023
Merged
@Deblintrake09 Deblintrake09 self-requested a review September 14, 2023 11:59
Deblintrake09
Deblintrake09 previously approved these changes Sep 14, 2023
View reviewed changes
Copy link
Contributor

@Deblintrake09 Deblintrake09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@damarisg damarisg merged commit 4105bbb into 4.6.0 Sep 15, 2023
@damarisg damarisg deleted the bug/4336-fix-ar-tests-error branch September 15, 2023 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damarisg damarisg damarisg approved these changes

@Deblintrake09 Deblintrake09 Deblintrake09 left review comments

Assignees

@mauromalara mauromalara

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Timeout in Active Response integration test
3 participants
@mauromalara @damarisg @Deblintrake09