Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix invalid AR conf in integration tests #4521

Merged
merged 4 commits into from
Sep 15, 2023
Merged

Conversation

juliamagan
Copy link
Member

@juliamagan juliamagan commented Sep 14, 2023

Related issue
#4516

Description

The ossec.log was showing 2023/09/11 12:38:29 wazuh-agent[1584] exec.c:65 at ReadExecConfig(): ERROR: (1313): Invalid active response config: 'shared/ar.conf'. because shared/ar.conf file started with an empty line due to:

with open(local_int_conf_path, 'w') as local_file_write:
local_file_write.write('\n'+debug_line)

We have deleted that extra line.

Updated

  • Updated tests/integration/test_active_response/test_execd/conftest.py

Testing performed

The test execution failed due to #4512, but we can see that the error log stopped appearing.

If we launch the test with the changes from #4511, the test passes:
passed-active-response.zip

Tester Test path Jenkins Local OS Commit Notes
@juliamagan (Developer) tests/integration/test_active_response 🟢 🟢 🟢 🟢 🟢 🟢 CentOS 8 8aedacb Manager
@juliamagan (Developer) tests/integration/test_active_response 🟢 🟢 🟢 🟢 🟢 🟢 CentOS 8 8aedacb Agent
@juliamagan (Developer) tests/integration/test_active_response 🔴 🔴 🔴 🔴 🔴 🔴 Windows Server 2016 8aedacb Failed as expected due to #4512

@juliamagan juliamagan self-assigned this Sep 14, 2023
@juliamagan juliamagan linked an issue Sep 14, 2023 that may be closed by this pull request
@juliamagan juliamagan marked this pull request as ready for review September 14, 2023 12:28
damarisg
damarisg previously approved these changes Sep 14, 2023
Copy link
Member

@damarisg damarisg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you update the CHANGELOG file, please?

@damarisg damarisg self-requested a review September 14, 2023 20:09
@damarisg damarisg merged commit 2b94e2b into 4.6.0 Sep 15, 2023
@damarisg damarisg deleted the fix/4516-invalid-ar-conf branch September 15, 2023 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalid shared configuration in Active Response integration test
2 participants