Update fields in cluster-service API to be snake_case #3237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarataha
force-pushed
the
api-fieldnames-update
branch
3 times, most recently
from
cf5d156 to
371a066
Compare
sarataha
force-pushed
the
api-fieldnames-update
branch
from
371a066 to
531cfc6
Compare
- And remove all a lot of unused code in the FE too
foot
reviewed
Sep 5, 2023
| rpc ListTemplateParams(ListTemplateParamsRequest) | ||
| returns (ListTemplateParamsResponse) { | ||
| option (google.api.http) = { | ||
| get : "/v1/templates/{template_name}/params" | ||
| }; | ||
| } | ||
|
|
||
| // Returns a list of profiles within that template | ||
| // `gitops get <template-name> --list-profiles` |
There was a problem hiding this comment.
Lets omit the cli command here.
The annotation mentioned here is no longer required too
AsmaaNabilBakr
pushed a commit
that referenced
this pull request
Sep 6, 2023
* Update fields in cluster-service API to be snake_case * Make sure all network requests in the UI use the protobuf types * And remove all a lot of unused code in the FE too --------- Co-authored-by: Simon Howe <[email protected]> Co-authored-by: Simon <[email protected]>
AsmaaNabilBakr
added a commit
that referenced
this pull request
Sep 6, 2023
* fix button spaces * remove unused imports * update snaps * remove unused styled components * Rename ui-cra -> ui and move package.json to root (#3263) * Search replace all the ui-cra to ui * and move package.json to root * run eject * Update fields in cluster-service API to be snake_case (#3237) * Update fields in cluster-service API to be snake_case * Make sure all network requests in the UI use the protobuf types * And remove all a lot of unused code in the FE too --------- Co-authored-by: Simon Howe <[email protected]> Co-authored-by: Simon <[email protected]> * Bump @adobe/css-tools from 4.2.0 to 4.3.1 (#3284) Bumps [@adobe/css-tools](https://github.com/adobe/css-tools) from 4.2.0 to 4.3.1. - [Changelog](https://github.com/adobe/css-tools/blob/main/History.md) - [Commits](https://github.com/adobe/css-tools/commits) --- updated-dependencies: - dependency-name: "@adobe/css-tools" dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Simon <[email protected]> * Bump async from 2.6.3 to 2.6.4 (#3285) Bumps [async](https://github.com/caolan/async) from 2.6.3 to 2.6.4. - [Release notes](https://github.com/caolan/async/releases) - [Changelog](https://github.com/caolan/async/blob/v2.6.4/CHANGELOG.md) - [Commits](caolan/async@v2.6.3...v2.6.4) --- updated-dependencies: - dependency-name: async dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Simon <[email protected]> * Explorer extending - gitopssets (#3267) * Add gitopsset kind to supported objects in explorer query * add gitopssets to rbac rules * Add gitopssets to ToFluxObject * Add gitopssets to getKindRoute fn in ui * Add gitopssets query server testcase to server integration tests * Use allowGitOpsSetsAnyOnDefaultNamespace for gitopsset support query server test * Add gitopssets crd to query suite test * changed category gitopsset (#3290) --------- Co-authored-by: Eneko Fernández <[email protected]> * update snaps --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Simon <[email protected]> Co-authored-by: Sara Elzayat <[email protected]> Co-authored-by: Simon Howe <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Rana Tarek Hassan <[email protected]> Co-authored-by: Eneko Fernández <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of: #3220
What changed?
Updated field names in cluster-service API to meet the styling guide, by changing field names to be
snake_caseRef: https://protobuf.dev/programming-guides/style/
Also ensured docstrings all make sense, and omitted the name of message (function) in the proto file.
We also go through to UI and
Why was this change made?
This is part of the API clean up before publishing it for customer usage.
How was this change implemented?
How did you validate the change?
Explain how a reviewer can verify the change themselves
API change, make sure everything still works
Integration tests -- what is covered, what cannot be covered;
Stil passing
Unit tests -- what is covered, what cannot be covered; are
Unit tests still passing
🍏 smoke https://github.com/weaveworks/weave-gitops-enterprise/actions/runs/6081289475
Release notes
Documentation Changes
Other follow ups