fix button spaces #3279
Merged
fix button spaces #3279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AsmaaNabilBakr
added
area/ui
and removed
ui_triage
AsmaaNabilBakr
added
ui_triage
| @@ -47,7 +47,7 @@ const WGApplicationsDashboard: FC = ({ className }: any) => { | |||
| ]} | |||
| > | |||
| <NotificationsWrapper errors={automations?.errors}> | |||
| <ActionsWrapper> | |||
| <ActionsWrapper gap="12"> | |||
There was a problem hiding this comment.
I believe 8px as a gap 'd be better . @alfaris
There was a problem hiding this comment.
Let it to be 12px as it's now on most of the designs and implementation
| @@ -60,10 +60,6 @@ interface Size { | |||
|
|
|||
| export const ActionsWrapper = styled(Flex)<Size>` | |||
| margin-bottom: ${({ theme }) => theme.spacing.medium}; | |||
There was a problem hiding this comment.
Now after we removed most of the styles, we don't need ActionWrapper anymore as we can depend on the gap in flex without setting margin
TheGostKasper
approved these changes
Sep 5, 2023
* Search replace all the ui-cra to ui * and move package.json to root * run eject
* Update fields in cluster-service API to be snake_case * Make sure all network requests in the UI use the protobuf types * And remove all a lot of unused code in the FE too --------- Co-authored-by: Simon Howe <[email protected]> Co-authored-by: Simon <[email protected]>
Bumps [@adobe/css-tools](https://github.com/adobe/css-tools) from 4.2.0 to 4.3.1. - [Changelog](https://github.com/adobe/css-tools/blob/main/History.md) - [Commits](https://github.com/adobe/css-tools/commits) --- updated-dependencies: - dependency-name: "@adobe/css-tools" dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Simon <[email protected]>
Bumps [async](https://github.com/caolan/async) from 2.6.3 to 2.6.4. - [Release notes](https://github.com/caolan/async/releases) - [Changelog](https://github.com/caolan/async/blob/v2.6.4/CHANGELOG.md) - [Commits](caolan/async@v2.6.3...v2.6.4) --- updated-dependencies: - dependency-name: async dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Simon <[email protected]>
* Add gitopsset kind to supported objects in explorer query * add gitopssets to rbac rules * Add gitopssets to ToFluxObject * Add gitopssets to getKindRoute fn in ui * Add gitopssets query server testcase to server integration tests * Use allowGitOpsSetsAnyOnDefaultNamespace for gitopsset support query server test * Add gitopssets crd to query suite test * changed category gitopsset (#3290) --------- Co-authored-by: Eneko Fernández <[email protected]>
AsmaaNabilBakr
added
area/ui
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3891
What changed?
This PR related to #3985 PR in
weave-gitopsto fix #3891 issue to updateActionWrapperfor buttons with a gap to fix spacing between them.How did you validate the change?
Explain how a reviewer can verify the change themselves
adjust-spacingbranch fromweave-gitopsEEmake core-ui && make core-libWEGO_EE_PROXY_HOST=https://demo-01.wge.dev.weave.works// yarn start