notify slack channel #tmp-smoke-failures smoke failures for allowing troubleshooting in the background #3648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enekofb
added
the
exclude from release notes
enekofb
commented
Nov 20, 2023
yiannistri
approved these changes
Nov 20, 2023
| secrets: | ||
| SLACK_BOT_TOKEN: ${{ secrets.SLACK_BOT_TOKEN }} |
There was a problem hiding this comment.
Let's remove this secret from the Settings, once this gets merged.
There was a problem hiding this comment.
i dont have admin permissions on the repo ... do you ? in case not, ill open a ticket with corp
enekofb
force-pushed
the
smoke-test-failures-notify
branch
from
f8cfde4 to
87eb2e2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3605
What changed?
Why was this change made?
How was this change implemented?
steps.{id}.outcomethat gives us the ability to detect failures while allowing the step to succeed in combination withcontinue-on-errorHow did you validate the change?
Run deploy workflow over a branch and see that in case of failures notifications are being sent to that slack channel.
An example here https://github.com/weaveworks/weave-gitops-enterprise/actions/runs/6927898025
Other follow ups