This repository has been archived by the owner on Jun 20, 2024. It is now read-only.
move plugin network creation/removal into weaveutil #1901
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's pointless and inconsistent. Firstly, deletion will fail if there are any attached containers. Secondly, we run the plugin with restart=always, so it will get restarted and the network re-created. Removal of the network does still happen on `weave stop|reset`, if possible.
This does require starting containerised weaveutil with docker.sock volume mounts.
Note that we remove the ability to set the weavemesh network name, or disabling it altogether. This was always poorly support, since the removal operation only ever operated on the default name. The option was also not listed in the usage, though it was in the docs.
|
btw, |
Nitpicking: it does not get restarted immediately if stopped by the user, e.g. |
Tracked at moby/moby#18363 |
bboreham
added a commit
that referenced
this pull request
Jan 15, 2016
move plugin network creation/removal into weaveutil
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main gotcha is that we lose the ability to specify a different mesh network name, or disable it altogether. That was always poorly supported and IMO is not worth losing sleep over until we / our users have a real need for it.
Closes #1897.