Skip to content
This repository has been archived by the owner on Jun 20, 2024. It is now read-only.

Remove Unix domain sockets on shutdown #1936

Merged
merged 2 commits into from
Jan 29, 2016
Merged

Remove Unix domain sockets on shutdown #1936

merged 2 commits into from
Jan 29, 2016

Conversation

bboreham
Copy link
Contributor

Fixes #1934.

Note part of #1901 will need to be re-done for the merge to master.

@bboreham bboreham added this to the 1.4.3 milestone Jan 28, 2016
@rade
Copy link
Member

rade commented Jan 28, 2016

This suffers from the scoping issue that I fixed in 31f736b, which means that the listener vars will always be nil. Also note that one or both of the addresses might be "" (and consequently one or both the listeners might be absent) - this isn't handled. Finally, there are a bunch of Log.Fatals that will bypass cleanup().

@bboreham
Copy link
Contributor Author

Equally the program could panic() and not run cleanup. I don't think it can be 100%.

@bboreham bboreham assigned rade and unassigned bboreham Jan 29, 2016
rade added a commit that referenced this pull request Jan 29, 2016
@rade
Merge pull request #1936 from /issues/1934-rm-socket
be9d64b 
Remove Unix domain sockets on shutdown

Fixes #1934.
@rade rade merged commit be9d64b into 1.4 Jan 29, 2016
@rade rade deleted the issues/1934-rm-socket branch January 29, 2016 15:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@rade rade

Labels
None yet
Projects
None yet
Milestone
1.4.3
Development

Successfully merging this pull request may close these issues.
2 participants
@bboreham @rade