-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: display title in frontmatter as heading fallback #1556
Conversation
✅ Deploy Preview for aquamarine-blini-95325f ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Thanks, I think this should be an opt-in feature with documented. |
@Timeless0911 This feature should be the default behavior as it does not introduce breaking changes. Do you have any concerns? |
The behavior of automatically adding titles should be made optional with |
This doesn't seem to be common. It's relatively rare for the page title to be different from the h1 heading. I prefer providing an option to opt-out rather than opt-in. |
Agreed. Providing an options is needed, and the default value can be true though.📌 |
46cffaf
to
1387b90
Compare
I added an |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I remember that in overview component, we deal title in a specific way, can you compatible with this case? rspress/packages/theme-default/src/components/Overview/index.tsx Lines 277 to 292 in c626c66
|
1387b90
to
32abcfe
Compare
Oh I forget that I think this PR is good enough to merge, thank you! |
Summary
Related Issue
close #1440
Checklist