Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(siderbar): sidebar is not stable in dev and sometimes is set by h1 in md #1675

Merged
merged 2 commits into from
Dec 19, 2024

Conversation

SoonIter
Copy link
Member

@SoonIter SoonIter commented Dec 18, 2024

Summary

  1. fix sidebar bug in dev

sidebar hmr has been invalid for a long time... so these codes are useless, we'll support sidebar hmr later by refactoring hmr (updating virtual-modules site-data json)

  1. add rspress-doc-title to h1
    related to feat: display title in frontmatter as heading fallback #1556

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copy link

netlify bot commented Dec 18, 2024

Deploy Preview for aquamarine-blini-95325f ready!

Name Link
🔨 Latest commit e7873bf
🔍 Latest deploy log https://app.netlify.com/sites/aquamarine-blini-95325f/deploys/67627b7a58c5f70008cca434
😎 Deploy Preview https://deploy-preview-1675--aquamarine-blini-95325f.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 91 (🟢 up 6 from production)
Accessibility: 97 (no change from production)
Best Practices: 92 (no change from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@SoonIter SoonIter changed the title fix(siderbar): hmr sidebar is not stable and is set by h1 fix(siderbar): sidebar is not stable in dev and sometimes is set by h1 in md Dec 18, 2024
@Timeless0911 Timeless0911 merged commit dfcbc44 into main Dec 19, 2024
10 checks passed
@Timeless0911 Timeless0911 deleted the fix/sidebar branch December 19, 2024 04:24
@Timeless0911 Timeless0911 mentioned this pull request Dec 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants