Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support nested container syntax in list and component in mdx-js #1741

Merged
merged 3 commits into from
Jan 13, 2025

Conversation

JounQin
Copy link
Contributor

@JounQin JounQin commented Jan 10, 2025

Summary

Related Issue

close #1513

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copy link

netlify bot commented Jan 10, 2025

Deploy Preview for aquamarine-blini-95325f ready!

Name Link
🔨 Latest commit 76cdd98
🔍 Latest deploy log https://app.netlify.com/sites/aquamarine-blini-95325f/deploys/6782613c7fc6800008219344
😎 Deploy Preview https://deploy-preview-1741--aquamarine-blini-95325f.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 87 (🔴 down 7 from production)
Accessibility: 97 (no change from production)
Best Practices: 92 (no change from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@JounQin JounQin force-pushed the fix/nested_container_syntax branch from 3b89d2d to b7d2f2e Compare January 10, 2025 17:41
@JounQin JounQin force-pushed the fix/nested_container_syntax branch from 555625d to 76cdd98 Compare January 11, 2025 12:16
@Timeless0911 Timeless0911 requested a review from SoonIter January 13, 2025 04:12
Copy link
Contributor

@Timeless0911 Timeless0911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you familiar with Rust, https://github.com/web-infra-dev/mdx-rs/blob/main/crates/plugin_container/src/lib.rs I think this feature is better to have in mdx-rs.

@JounQin
Copy link
Contributor Author

JounQin commented Jan 13, 2025

Do you familiar with Rust, web-infra-dev/mdx-rs@main/crates/plugin_container/src/lib.rs I think this feature is better to have in mdx-rs.

Not quite, but I'll give it a try.

@Timeless0911 Timeless0911 changed the title fix: support nested container syntax in list and component fix: support nested container syntax in list and component in mdx-js Jan 13, 2025
@Timeless0911 Timeless0911 changed the title fix: support nested container syntax in list and component in mdx-js feat: support nested container syntax in list and component in mdx-js Jan 13, 2025
@Timeless0911 Timeless0911 merged commit 4f17eed into web-infra-dev:main Jan 13, 2025
9 checks passed
@Timeless0911
Copy link
Contributor

@SoonIter Can you help @JounQin with implementation of this feature in mdx-rs?

@JounQin
Copy link
Contributor Author

JounQin commented Jan 13, 2025

@Timeless0911 @SoonIter Please help to review web-infra-dev/mdx-rs#69

@Timeless0911
Copy link
Contributor

@Timeless0911 @SoonIter Please help to review web-infra-dev/mdx-rs#69

Awesome, you can bump @rspress/mdx-rs and write some e2e tests in @rspress-fixture/github-alert-mdxrs after @SoonIter publishing it.

@Timeless0911
Copy link
Contributor

@rspress/[email protected] is released.

@JounQin
Copy link
Contributor Author

JounQin commented Jan 13, 2025

@Timeless0911 #1745

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Container syntax inside lists or other components are not rendered
2 participants