Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support nested container syntax in list in mdx-rs #1745

Merged

Conversation

JounQin
Copy link
Contributor

@JounQin JounQin commented Jan 13, 2025

Summary

Related Issue

close #1513

related web-infra-dev/mdx-rs#69

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copy link

netlify bot commented Jan 13, 2025

Deploy Preview for aquamarine-blini-95325f ready!

Name Link
🔨 Latest commit d6abdc0
🔍 Latest deploy log https://app.netlify.com/sites/aquamarine-blini-95325f/deploys/6784d08f7a972600081f7668
😎 Deploy Preview https://deploy-preview-1745--aquamarine-blini-95325f.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 84 (🟢 up 2 from production)
Accessibility: 97 (no change from production)
Best Practices: 92 (no change from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@Timeless0911
Copy link
Contributor

Timeless0911 commented Jan 13, 2025

Seems that it not work on components in mdx-rs but mdx-js do. Maybe the implementation of mdx-rs is not strictly align with mdx-js already before.

## In Steps

import { Steps } from '@theme';

<Steps>
### Title1

:::tip
This is a tip.
:::

### Title2
</Steps>

@JounQin
Copy link
Contributor Author

JounQin commented Jan 13, 2025

in mdx-rs, the ast is hast, but in mdx-js, it's mdast, not sure how Steps is presented in hast.

See also #1527 (comment)

@Timeless0911
Copy link
Contributor

I think we should think more about the future of mdxrs in Rspress 2.0. @SoonIter

@Timeless0911 Timeless0911 changed the title feat: support nested container syntax in list and component in mdx-rs feat: support nested container syntax in list in mdx-rs Jan 13, 2025
@Timeless0911 Timeless0911 merged commit 5048d75 into web-infra-dev:main Jan 13, 2025
9 checks passed
@JounQin JounQin deleted the feat/nested_container_syntax branch January 13, 2025 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Container syntax inside lists or other components are not rendered
2 participants