Performance issue fix

[chanar]

Found out that the performance issue was caused by looping through files in the bash scripts. Instead, the files from the provided path will be looped inside js.

Also, changed watch script to compile the changed file directly.

[web-padawan]

Thanks for the PR. Will take a look in the evening.

In the meanwhile, could you remove commit adding addon-viewport from this branch for now?
I would recommend making granular PRs as that would be easier to review.

[chanar]

Could we also use /src/styles as an output path instead of /src/components/styles ? This would mean changing currently imported css.js's path one folder back but would make it more acceptable for different types of packages which don't necessarily have components.

[web-padawan]

@chanar we could change the output path, if you think it makes sense e.g. to allow utility files like abu-theme.css.js to be used on their own, which someone would potentially want.

[lkraav]

@chanar squash / amend top commits, don't add reverts etc noise.

[chanar]

@lkraav squashing is for merging two commits. Amending is for changing the commit message.

[chanar]

@web-padawan I think it makes sense for encouraging adoption and using your framework packages in parallel with someone's own app. But I would wait until if you decide to merge this pull request and then make a new PR for the path changes.

[lkraav]

@chanar can you please comment on why eslint seems to be forcing formatting changes into the commit? This is making the PR very hard to review. @web-padawan is such configuration intentional, or?

[chanar]

aybolit/package.json

Line 87 in 889df60

"eslint --fix",

Not sure why it didn't do changes for padawan in master, to begin with.

[web-padawan]

@lkraav it looks like I haven't run some scripts through prettier yet. The formatting changes are ok.

[lkraav]

$ [git:scripts-edits?{1}] yarn watch
yarn run v1.15.2
$ node scripts/watcher.js
watcher started!
saw change to packages/white-label/scss/abw-button.scss
building styles

watcher build complete!

@chanar build was definitely very fast (since only the relevant component built), but there seems to be no output of what was built where (target), for clarity. Easy or not to add?

[web-padawan]

LGTM. Will update and to merge into a branch first, so I could run the tests before merging to master.

[lkraav]

@chanar legacy for loop was excluding ^_ glob pattern to avoid building partials.

watcher build complete!
saw change to packages/bootstrap/scss/_variables.scss
building styles

watcher build complete!

Your JS globbing seems to have missed it.