Skip to content
This repository has been archived by the owner on Jul 30, 2022. It is now read-only.

chore: update sass render script to work faster #18

Merged
merged 7 commits into from
Apr 10, 2019
Merged

Conversation

web-padawan
Copy link
Owner

No description provided.

@lkraav
Copy link
Contributor

lkraav commented Apr 10, 2019

@web-padawan should I migrate my QA findings here, or you are picking them up from #17

@web-padawan
Copy link
Owner Author

@lkraav this PR is a copy of #17 and I now when it passed I will go ahead and merge it.
Let's continue sass-render discussion in #15 if you wish, or submit another PR.

@lkraav
Copy link
Contributor

lkraav commented Apr 10, 2019

Oooh, I meant "picking them up from #17"

@web-padawan
Copy link
Owner Author

Agree about #17 (comment)
I will tweak this PR to exclude these internal files starting with _

@lkraav
Copy link
Contributor

lkraav commented Apr 10, 2019

Also, info message about generated target output would be nice.

@web-padawan
Copy link
Owner Author

Updated the code and moved sass-render to separate package, also fixed few lint errors.

@lkraav
Copy link
Contributor

lkraav commented Apr 10, 2019

@web-padawan maybe line capitalization was left a little bit inconsistent for messages. All sentence-case, perhaps?

/usr/bin/node /usr/lib/node_modules/yarn/bin/yarn.js run watch
yarn run v1.15.2
$ node scripts/watcher.js
watcher started!
saw change to packages/core/scss/button-base.scss
building styles
Processing packages/core/scss/button-base.scss

watcher build complete!

@web-padawan
Copy link
Owner Author

Sure, I will update it. Thanks, also noticed that yesterday while trying watcher.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants