Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove compat keys for line-clamp #794

Merged
merged 1 commit into from
Apr 9, 2024
Merged

Remove compat keys for line-clamp #794

merged 1 commit into from
Apr 9, 2024

Conversation

foolip
Copy link
Collaborator

@foolip foolip commented Apr 5, 2024

We will most likely need to handle this feature manually and decide if we want it to cover just the unprefixed line-clamp or also -webkit-line-clamp. To avoid computing anything automatically, remove the compat keys.

We will most likely need to handle this feature manually and decide if we want it to cover just the unprefixed `line-clamp` or also `-webkit-line-clamp`. To avoid computing anything automatically, remove the compat keys.
@foolip foolip requested a review from ddbeck April 5, 2024 12:12
Copy link
Collaborator

@ddbeck ddbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should I retire #503 as well? Or hold that open as a testing ground for notes?

@foolip
Copy link
Collaborator Author

foolip commented Apr 9, 2024

@ddbeck leaving that open as a reminder seems good, but you can set it to draft if you don't want to figure this out right now.

@foolip foolip merged commit 0090b20 into main Apr 9, 2024
2 checks passed
@foolip foolip deleted the webkit-line-clamp branch April 9, 2024 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants