Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

idlharness.js does not handle newly renamed extended attributes #23148

Closed
stephenmcgruer opened this issue Apr 21, 2020 · 3 comments
Closed

idlharness.js does not handle newly renamed extended attributes #23148

stephenmcgruer opened this issue Apr 21, 2020 · 3 comments
Assignees
@stephenmcgruer
Labels
infra priority:roadmap

Comments

@stephenmcgruer
Copy link
Contributor

stephenmcgruer commented Apr 21, 2020 •
edited
Loading

WebIDL just renamed a bunch of attributes in whatwg/webidl#870, and the upstream changes have started rolling in:

Since idlharness doesn't know about these, these changes introduce errors.

My plan is to tackle the attributes as they appear in imported IDL files, rather than try to get ahead of them.
@stephenmcgruer stephenmcgruer self-assigned this Apr 21, 2020
stephenmcgruer added a commit that referenced this issue Apr 21, 2020
@stephenmcgruer
Update interfaces/html.idl
3e44a8d 
Includes necessary idlharness.js updates for
#23148

Closes #23124
@stephenmcgruer stephenmcgruer mentioned this issue Apr 21, 2020
Merged
stephenmcgruer added a commit that referenced this issue Apr 23, 2020
@stephenmcgruer
Update interfaces/fullscreen.idl
31ace08 
Includes necessary idlharness.js updates for
#23148

Closes #23128
@stephenmcgruer stephenmcgruer mentioned this issue Apr 23, 2020
Merged
stephenmcgruer added a commit that referenced this issue Apr 24, 2020
@stephenmcgruer
Update interfaces/html.idl (#23150)
513fe4f 
Includes necessary idlharness.js updates (handling XYZ --> LegacyXYZ
renames) for #23148

Closes #23124
foolip pushed a commit that referenced this issue Apr 27, 2020
@stephenmcgruer
Update interfaces/fullscreen.idl (#23207)
7b4b5b8 
Includes necessary idlharness.js updates for
#23148

Closes #23128
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this issue May 1, 2020
@stephenmcgruer @moz-wptsync-bot
Bug 1631900 [wpt PR 23150] - Update interfaces/html.idl, a=testonly
e0a8a45 
Automatic update from web-platform-tests
Update interfaces/html.idl (#23150)

Includes necessary idlharness.js updates (handling XYZ --> LegacyXYZ
renames) for web-platform-tests/wpt#23148

Closes web-platform-tests/wpt#23124
--

wpt-commits: 513fe4fe493fd1215987460781345e9fc4cc7b0d
wpt-pr: 23150
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this issue May 1, 2020
@stephenmcgruer @moz-wptsync-bot
Bug 1632580 [wpt PR 23207] - Update interfaces/fullscreen.idl, a=test…
810c4c8 
…only

Automatic update from web-platform-tests
Update interfaces/fullscreen.idl (#23207)

Includes necessary idlharness.js updates for
web-platform-tests/wpt#23148

Closes web-platform-tests/wpt#23128
--

wpt-commits: 7b4b5b84caae9e748eb13fda010d48a6a874e5a4
wpt-pr: 23207
xeonchen pushed a commit to xeonchen/gecko that referenced this issue May 1, 2020
@stephenmcgruer @moz-wptsync-bot
Bug 1631900 [wpt PR 23150] - Update interfaces/html.idl, a=testonly
23b480a 
Automatic update from web-platform-tests
Update interfaces/html.idl (#23150)

Includes necessary idlharness.js updates (handling XYZ --> LegacyXYZ
renames) for web-platform-tests/wpt#23148

Closes web-platform-tests/wpt#23124
--

wpt-commits: 513fe4fe493fd1215987460781345e9fc4cc7b0d
wpt-pr: 23150
xeonchen pushed a commit to xeonchen/gecko that referenced this issue May 1, 2020
@stephenmcgruer @moz-wptsync-bot
Bug 1632580 [wpt PR 23207] - Update interfaces/fullscreen.idl, a=test…
f693d1a 
…only

Automatic update from web-platform-tests
Update interfaces/fullscreen.idl (#23207)

Includes necessary idlharness.js updates for
web-platform-tests/wpt#23148

Closes web-platform-tests/wpt#23128
--

wpt-commits: 7b4b5b84caae9e748eb13fda010d48a6a874e5a4
wpt-pr: 23207
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this issue May 1, 2020
@stephenmcgruer
Bug 1631900 [wpt PR 23150] - Update interfaces/html.idl, a=testonly
38cf60f 
Automatic update from web-platform-tests
Update interfaces/html.idl (#23150)

Includes necessary idlharness.js updates (handling XYZ --> LegacyXYZ
renames) for web-platform-tests/wpt#23148

Closes web-platform-tests/wpt#23124
--

wpt-commits: 513fe4fe493fd1215987460781345e9fc4cc7b0d
wpt-pr: 23150
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this issue May 1, 2020
@stephenmcgruer
Bug 1632580 [wpt PR 23207] - Update interfaces/fullscreen.idl, a=test…
080c310 
…only

Automatic update from web-platform-tests
Update interfaces/fullscreen.idl (#23207)

Includes necessary idlharness.js updates for
web-platform-tests/wpt#23148

Closes web-platform-tests/wpt#23128
--

wpt-commits: 7b4b5b84caae9e748eb13fda010d48a6a874e5a4
wpt-pr: 23207
xeonchen pushed a commit to xeonchen/gecko that referenced this issue May 1, 2020
@stephenmcgruer
Bug 1631900 [wpt PR 23150] - Update interfaces/html.idl, a=testonly
3b96776 
Automatic update from web-platform-tests
Update interfaces/html.idl (#23150)

Includes necessary idlharness.js updates (handling XYZ --> LegacyXYZ
renames) for web-platform-tests/wpt#23148

Closes web-platform-tests/wpt#23124
--

wpt-commits: 513fe4fe493fd1215987460781345e9fc4cc7b0d
wpt-pr: 23150
xeonchen pushed a commit to xeonchen/gecko that referenced this issue May 1, 2020
@stephenmcgruer
Bug 1632580 [wpt PR 23207] - Update interfaces/fullscreen.idl, a=test…
6aff338 
…only

Automatic update from web-platform-tests
Update interfaces/fullscreen.idl (#23207)

Includes necessary idlharness.js updates for
web-platform-tests/wpt#23148

Closes web-platform-tests/wpt#23128
--

wpt-commits: 7b4b5b84caae9e748eb13fda010d48a6a874e5a4
wpt-pr: 23207
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this issue May 3, 2020
@marco-c
Bug 1631900 [wpt PR 23150] - Update interfaces/html.idl, a=testonly
e5517e7 
Automatic update from web-platform-tests
Update interfaces/html.idl (#23150)

Includes necessary idlharness.js updates (handling XYZ --> LegacyXYZ
renames) for web-platform-tests/wpt#23148

Closes web-platform-tests/wpt#23124
--

wpt-commits: 513fe4fe493fd1215987460781345e9fc4cc7b0d
wpt-pr: 23150

UltraBlame original commit: d5aefccd6b07332f0b13a0f76d0f4aca200134f8
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this issue May 3, 2020
@marco-c
Bug 1632580 [wpt PR 23207] - Update interfaces/fullscreen.idl, a=test…
5de8109 
…only

Automatic update from web-platform-tests
Update interfaces/fullscreen.idl (#23207)

Includes necessary idlharness.js updates for
web-platform-tests/wpt#23148

Closes web-platform-tests/wpt#23128
--

wpt-commits: 7b4b5b84caae9e748eb13fda010d48a6a874e5a4
wpt-pr: 23207

UltraBlame original commit: 65842dd31fb2f0b8b2b7087fb7f27a63e4e501f0
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this issue May 3, 2020
@marco-c
Bug 1631900 [wpt PR 23150] - Update interfaces/html.idl, a=testonly
e4b7356 
Automatic update from web-platform-tests
Update interfaces/html.idl (#23150)

Includes necessary idlharness.js updates (handling XYZ --> LegacyXYZ
renames) for web-platform-tests/wpt#23148

Closes web-platform-tests/wpt#23124
--

wpt-commits: 513fe4fe493fd1215987460781345e9fc4cc7b0d
wpt-pr: 23150

UltraBlame original commit: 3d240952f1977fb63a054c6711d4a530359a2cda
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this issue May 3, 2020
@marco-c
Bug 1632580 [wpt PR 23207] - Update interfaces/fullscreen.idl, a=test…
a707644 
…only

Automatic update from web-platform-tests
Update interfaces/fullscreen.idl (#23207)

Includes necessary idlharness.js updates for
web-platform-tests/wpt#23148

Closes web-platform-tests/wpt#23128
--

wpt-commits: 7b4b5b84caae9e748eb13fda010d48a6a874e5a4
wpt-pr: 23207

UltraBlame original commit: c494ab0b6fab0dd339b7ca6fc13c36ad56e19568
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this issue May 3, 2020
@marco-c
Bug 1631900 [wpt PR 23150] - Update interfaces/html.idl, a=testonly
ceedb30 
Automatic update from web-platform-tests
Update interfaces/html.idl (#23150)

Includes necessary idlharness.js updates (handling XYZ --> LegacyXYZ
renames) for web-platform-tests/wpt#23148

Closes web-platform-tests/wpt#23124
--

wpt-commits: 513fe4fe493fd1215987460781345e9fc4cc7b0d
wpt-pr: 23150

UltraBlame original commit: d5aefccd6b07332f0b13a0f76d0f4aca200134f8
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this issue May 3, 2020
@marco-c
Bug 1632580 [wpt PR 23207] - Update interfaces/fullscreen.idl, a=test…
4ecb31e 
…only

Automatic update from web-platform-tests
Update interfaces/fullscreen.idl (#23207)

Includes necessary idlharness.js updates for
web-platform-tests/wpt#23148

Closes web-platform-tests/wpt#23128
--

wpt-commits: 7b4b5b84caae9e748eb13fda010d48a6a874e5a4
wpt-pr: 23207

UltraBlame original commit: 65842dd31fb2f0b8b2b7087fb7f27a63e4e501f0
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this issue May 3, 2020
@marco-c
Bug 1631900 [wpt PR 23150] - Update interfaces/html.idl, a=testonly
8daa073 
Automatic update from web-platform-tests
Update interfaces/html.idl (#23150)

Includes necessary idlharness.js updates (handling XYZ --> LegacyXYZ
renames) for web-platform-tests/wpt#23148

Closes web-platform-tests/wpt#23124
--

wpt-commits: 513fe4fe493fd1215987460781345e9fc4cc7b0d
wpt-pr: 23150

UltraBlame original commit: 3d240952f1977fb63a054c6711d4a530359a2cda
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this issue May 3, 2020
@marco-c
Bug 1632580 [wpt PR 23207] - Update interfaces/fullscreen.idl, a=test…
b7588cf 
…only

Automatic update from web-platform-tests
Update interfaces/fullscreen.idl (#23207)

Includes necessary idlharness.js updates for
web-platform-tests/wpt#23148

Closes web-platform-tests/wpt#23128
--

wpt-commits: 7b4b5b84caae9e748eb13fda010d48a6a874e5a4
wpt-pr: 23207

UltraBlame original commit: c494ab0b6fab0dd339b7ca6fc13c36ad56e19568
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this issue May 3, 2020
@marco-c
Bug 1631900 [wpt PR 23150] - Update interfaces/html.idl, a=testonly
5dc9d5a 
Automatic update from web-platform-tests
Update interfaces/html.idl (#23150)

Includes necessary idlharness.js updates (handling XYZ --> LegacyXYZ
renames) for web-platform-tests/wpt#23148

Closes web-platform-tests/wpt#23124
--

wpt-commits: 513fe4fe493fd1215987460781345e9fc4cc7b0d
wpt-pr: 23150

UltraBlame original commit: d5aefccd6b07332f0b13a0f76d0f4aca200134f8
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this issue May 3, 2020
@marco-c
Bug 1632580 [wpt PR 23207] - Update interfaces/fullscreen.idl, a=test…
92549a7 
…only

Automatic update from web-platform-tests
Update interfaces/fullscreen.idl (#23207)

Includes necessary idlharness.js updates for
web-platform-tests/wpt#23148

Closes web-platform-tests/wpt#23128
--

wpt-commits: 7b4b5b84caae9e748eb13fda010d48a6a874e5a4
wpt-pr: 23207

UltraBlame original commit: 65842dd31fb2f0b8b2b7087fb7f27a63e4e501f0
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this issue May 3, 2020
@marco-c
Bug 1631900 [wpt PR 23150] - Update interfaces/html.idl, a=testonly
db5f440 
Automatic update from web-platform-tests
Update interfaces/html.idl (#23150)

Includes necessary idlharness.js updates (handling XYZ --> LegacyXYZ
renames) for web-platform-tests/wpt#23148

Closes web-platform-tests/wpt#23124
--

wpt-commits: 513fe4fe493fd1215987460781345e9fc4cc7b0d
wpt-pr: 23150

UltraBlame original commit: 3d240952f1977fb63a054c6711d4a530359a2cda
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this issue May 3, 2020
@marco-c
Bug 1632580 [wpt PR 23207] - Update interfaces/fullscreen.idl, a=test…
3cf108f 
…only

Automatic update from web-platform-tests
Update interfaces/fullscreen.idl (#23207)

Includes necessary idlharness.js updates for
web-platform-tests/wpt#23148

Closes web-platform-tests/wpt#23128
--

wpt-commits: 7b4b5b84caae9e748eb13fda010d48a6a874e5a4
wpt-pr: 23207

UltraBlame original commit: c494ab0b6fab0dd339b7ca6fc13c36ad56e19568
stephenmcgruer added a commit that referenced this issue Jun 24, 2020
@stephenmcgruer
[idlharness] Remove old names for legacy extended attributes
c8ecf21 
The following attributes don't seem to have code relating to them in
idlharness:
  - OverrideBuiltins / LegacyOverrideBuiltIns
  - TreatNonObjectAsNull / LegacyTreatNonObjectAsNull
  - TreatNullAs=EmptyString / LegacyNullToEmptyString

Finally, didn't touch NoInterfaceObject yet as there appear to be no
specs that mention it or its replacement LegacyNoInterfaceObject in
interfaces/*.idl.

See #23148
@stephenmcgruer stephenmcgruer mentioned this issue Jun 24, 2020
Merged
stephenmcgruer added a commit that referenced this issue Jun 24, 2020
@stephenmcgruer
[idlharness] Remove old names for legacy extended attributes
bc08ef7 
The following attributes don't seem to have code relating to them in
idlharness:
  - OverrideBuiltins / LegacyOverrideBuiltIns
  - TreatNonObjectAsNull / LegacyTreatNonObjectAsNull
  - TreatNullAs=EmptyString / LegacyNullToEmptyString

Finally, didn't touch NoInterfaceObject yet as there appear to be no
specs that mention it or its replacement LegacyNoInterfaceObject in
interfaces/*.idl.

See #23148
stephenmcgruer added a commit that referenced this issue Jun 24, 2020
@stephenmcgruer
[idlharness] Remove old names for legacy extended attributes (#24324)
f50d16f 
The following attributes don't seem to have code relating to them in
idlharness:
  - OverrideBuiltins / LegacyOverrideBuiltIns
  - TreatNonObjectAsNull / LegacyTreatNonObjectAsNull
  - TreatNullAs=EmptyString / LegacyNullToEmptyString

Finally, didn't touch NoInterfaceObject yet as there appear to be no
specs that mention it or its replacement LegacyNoInterfaceObject in
interfaces/*.idl.

See #23148
@stephenmcgruer
Copy link
Contributor Author

So LegacyNoInterfaceObject is not supported still, but all the rest are and we have no specs that use LegacyNoInterfaceObject. I'm happy to leave that until we someday get a spec that uses it.

@foolip
Copy link
Member

foolip commented Jul 1, 2020

If no specs currently use LegacyNoInterfaceObject then probably none ever will. The only spec left in reffy-reports (ed) using NoInterfaceObject (the "legacy" name of LegacyNoInterfaceObject :D) is svg-paths.idl, being added in #23869. It'd probably be best to fix that at the source and then just drop support for NoInterfaceObject from WPT.

@foolip
Copy link
Member

foolip commented Jul 1, 2020

I've sent w3c/svgwg#802 for that.

moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this issue Jul 1, 2020
@stephenmcgruer @moz-wptsync-bot
Bug 1647959 [wpt PR 24324] - [idlharness] Remove old names for legacy…
cfc0368 
… extended attributes, a=testonly

Automatic update from web-platform-tests
[idlharness] Remove old names for legacy extended attributes (#24324)

The following attributes don't seem to have code relating to them in
idlharness:
  - OverrideBuiltins / LegacyOverrideBuiltIns
  - TreatNonObjectAsNull / LegacyTreatNonObjectAsNull
  - TreatNullAs=EmptyString / LegacyNullToEmptyString

Finally, didn't touch NoInterfaceObject yet as there appear to be no
specs that mention it or its replacement LegacyNoInterfaceObject in
interfaces/*.idl.

See web-platform-tests/wpt#23148
--

wpt-commits: f50d16f119d200ae2abbab7d51e80a48f156059c
wpt-pr: 24324
hsivonen pushed a commit to hsivonen/gecko that referenced this issue Jul 3, 2020
@stephenmcgruer @moz-wptsync-bot
Bug 1647959 [wpt PR 24324] - [idlharness] Remove old names for legacy…
3dafe95 
… extended attributes, a=testonly

Automatic update from web-platform-tests
[idlharness] Remove old names for legacy extended attributes (#24324)

The following attributes don't seem to have code relating to them in
idlharness:
  - OverrideBuiltins / LegacyOverrideBuiltIns
  - TreatNonObjectAsNull / LegacyTreatNonObjectAsNull
  - TreatNullAs=EmptyString / LegacyNullToEmptyString

Finally, didn't touch NoInterfaceObject yet as there appear to be no
specs that mention it or its replacement LegacyNoInterfaceObject in
interfaces/*.idl.

See web-platform-tests/wpt#23148
--

wpt-commits: f50d16f119d200ae2abbab7d51e80a48f156059c
wpt-pr: 24324
i3roly pushed a commit to i3roly/firefox-dynasty that referenced this issue Jun 1, 2024
@stephenmcgruer @moz-wptsync-bot
Bug 1647959 [wpt PR 24324] - [idlharness] Remove old names for legacy…
5f6bba9 
… extended attributes, a=testonly

Automatic update from web-platform-tests
[idlharness] Remove old names for legacy extended attributes (#24324)

The following attributes don't seem to have code relating to them in
idlharness:
  - OverrideBuiltins / LegacyOverrideBuiltIns
  - TreatNonObjectAsNull / LegacyTreatNonObjectAsNull
  - TreatNullAs=EmptyString / LegacyNullToEmptyString

Finally, didn't touch NoInterfaceObject yet as there appear to be no
specs that mention it or its replacement LegacyNoInterfaceObject in
interfaces/*.idl.

See web-platform-tests/wpt#23148
--

wpt-commits: f50d16f119d200ae2abbab7d51e80a48f156059c
wpt-pr: 24324
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stephenmcgruer stephenmcgruer

Labels
infra priority:roadmap
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@stephenmcgruer @foolip