Origin isolation: rename the getter (but leave an alias) #25052
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Aug 17, 2020
|
This will need admin merge per #23364. (Probably should wait on the Chrome CL to finish up first; I need to update global-interface-listing... that might happen overnight though.) |
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2353013
branch
2 times, most recently
from
6efa175 to
c1e7d63
Compare
This renames window.originIsolationRestricted to window.originIsolated per the latest spec changes. This largely amounts to massive test updates. window.originIsolationRestricted is retained as an alias for the duration of the origin trial so as to avoid breaking deployed code, and a wpt_internal test ensures this. Bug: 1103866 Change-Id: I4f570c79d19dc783d40beb3549d677555d1c81af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353013 Commit-Queue: Domenic Denicola <[email protected]> Reviewed-by: James MacLean <[email protected]> Reviewed-by: Nate Chapin <[email protected]> Cr-Commit-Position: refs/heads/master@{#799235}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2353013
branch
from
c1e7d63 to
95fd9c6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This renames window.originIsolationRestricted to window.originIsolated
per the latest spec changes. This largely amounts to massive test
updates.
window.originIsolationRestricted is retained as an alias for the
duration of the origin trial so as to avoid breaking deployed code, and
a wpt_internal test ensures this.
Bug: 1103866
Change-Id: I4f570c79d19dc783d40beb3549d677555d1c81af
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353013
Commit-Queue: Domenic Denicola <[email protected]>
Reviewed-by: James MacLean <[email protected]>
Reviewed-by: Nate Chapin <[email protected]>
Cr-Commit-Position: refs/heads/master@{#799235}