Origin isolation: add initial popup WPTs #25109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Aug 19, 2020
This introduces a couple basic web platform tests for the popup cases. The main content of this CL is generalizing the test infrastructure, which previous was iframe-specific. Subsequent CLs will add a more comprehensive suite of popup tests. Bug: 1042415 Change-Id: I4f993783613f32cf9ebfb10e29973820e2fc9aad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364057 Reviewed-by: James MacLean <[email protected]> Commit-Queue: Domenic Denicola <[email protected]> Cr-Commit-Position: refs/heads/master@{#799695}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2364057
branch
from
8a21c97 to
86d280c
Compare
|
wpt-chrome-dev-stability failure in https://github.com/web-platform-tests/wpt/pull/25109/checks?check_run_id=1004257724. origin-isolation/removing-iframes.sub.https.html wasn't touched in this change. It was last touched in #25052, where stability also failed, with reference to #23364. I will admin merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces a couple basic web platform tests for the popup cases.
The main content of this CL is generalizing the test infrastructure,
which previous was iframe-specific. Subsequent CLs will add a more
comprehensive suite of popup tests.
Bug: 1042415
Change-Id: I4f993783613f32cf9ebfb10e29973820e2fc9aad
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364057
Reviewed-by: James MacLean <[email protected]>
Commit-Queue: Domenic Denicola <[email protected]>
Cr-Commit-Position: refs/heads/master@{#799695}