-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[webtransport_h3_server] Support RFC version of HTTP Datagrams #39201
Conversation
There is no significant semantics changes between draft04[1] and rfc[2]. * Capsule protocol was simlified. * HTTP Setting value has changed. [1] https://datatracker.ietf.org/doc/html/draft-ietf-masque-h3-datagram-04 [2] https://datatracker.ietf.org/doc/html/rfc9297
There are no reviewers for this pull request besides its author. Please reach out on the chat room to get help with this. Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with nits :) Sorry for the delay!
""" | ||
A H3Connection subclass, to make it work with the latest | ||
HTTP Datagram protocol. | ||
""" | ||
H3_DATAGRAM_04 = 0xffd277 | ||
# https://datatracker.ietf.org/doc/html/draft-ietf-httpbis-h3-websockets-00#section-5 | ||
# https://datatracker.ietf.org/doc/html/rfc9220#name-iana-considerations |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: Should this be https://datatracker.ietf.org/doc/html/rfc9220#section-5-2.2.1 to be more specific?
data=capsule.data, fin=fin) | ||
else: | ||
# Ignore unknown capsules. | ||
pass |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should be return
to be consistent with line 195.
I'm not sure why https://github.com/web-platform-tests/wpt/pull/39201/checks?check_run_id=12413093400 is happening. I think we disable the test on Firefox (https://github.com/web-platform-tests/wpt/blob/master/infrastructure/metadata/infrastructure/server/webtransport-h3.https.sub.any.js.ini) |
These tests are timing out on Firefox macOS and blocking unrelated PRs (e.g., web-platform-tests#39196, web-platform-tests#39201, web-platform-tests#39227): ``` /infrastructure/server/webtransport-h3.https.sub.any.serviceworker.html TIMEOUT WebTransport server should be running and should handle a bidirectional stream - Test timed out TIMEOUT /infrastructure/server/webtransport-h3.https.sub.any.serviceworker.html /infrastructure/server/webtransport-h3.https.sub.any.worker.html TIMEOUT WebTransport server should be running and should handle a bidirectional stream - Test timed out TIMEOUT /infrastructure/server/webtransport-h3.https.sub.any.worker.html /infrastructure/server/webtransport-h3.https.sub.any.sharedworker.html TIMEOUT WebTransport server should be running and should handle a bidirectional stream - Test timed out TIMEOUT /infrastructure/server/webtransport-h3.https.sub.any.sharedworker.html /infrastructure/server/webtransport-h3.https.sub.any.html TIMEOUT WebTransport server should be running and should handle a bidirectional stream - Test timed out TIMEOUT /infrastructure/server/webtransport-h3.https.sub.any.html ``` Disable them for now. Also, remove the `.any.window.html` section, which is redundant with `.any.html`.
These tests are timing out on Firefox macOS and blocking unrelated PRs (e.g., web-platform-tests#39196, web-platform-tests#39201, web-platform-tests#39227): ``` /infrastructure/server/webtransport-h3.https.sub.any.serviceworker.html TIMEOUT WebTransport server should be running and should handle a bidirectional stream - Test timed out TIMEOUT /infrastructure/server/webtransport-h3.https.sub.any.serviceworker.html /infrastructure/server/webtransport-h3.https.sub.any.worker.html TIMEOUT WebTransport server should be running and should handle a bidirectional stream - Test timed out TIMEOUT /infrastructure/server/webtransport-h3.https.sub.any.worker.html /infrastructure/server/webtransport-h3.https.sub.any.sharedworker.html TIMEOUT WebTransport server should be running and should handle a bidirectional stream - Test timed out TIMEOUT /infrastructure/server/webtransport-h3.https.sub.any.sharedworker.html /infrastructure/server/webtransport-h3.https.sub.any.html TIMEOUT WebTransport server should be running and should handle a bidirectional stream - Test timed out TIMEOUT /infrastructure/server/webtransport-h3.https.sub.any.html ``` Disable them for now. Also, remove the `.any.window.html` section, which is redundant with `.any.html`.
These tests are timing out on Firefox macOS and blocking unrelated PRs (e.g., #39196, #39201, #39227): ``` /infrastructure/server/webtransport-h3.https.sub.any.serviceworker.html TIMEOUT WebTransport server should be running and should handle a bidirectional stream - Test timed out TIMEOUT /infrastructure/server/webtransport-h3.https.sub.any.serviceworker.html /infrastructure/server/webtransport-h3.https.sub.any.worker.html TIMEOUT WebTransport server should be running and should handle a bidirectional stream - Test timed out TIMEOUT /infrastructure/server/webtransport-h3.https.sub.any.worker.html /infrastructure/server/webtransport-h3.https.sub.any.sharedworker.html TIMEOUT WebTransport server should be running and should handle a bidirectional stream - Test timed out TIMEOUT /infrastructure/server/webtransport-h3.https.sub.any.sharedworker.html /infrastructure/server/webtransport-h3.https.sub.any.html TIMEOUT WebTransport server should be running and should handle a bidirectional stream - Test timed out TIMEOUT /infrastructure/server/webtransport-h3.https.sub.any.html ``` Disable them for now. Also, remove the `.any.window.html` section, which is redundant with `.any.html`.
These tests are timing out on Firefox macOS and blocking unrelated PRs (e.g., web-platform-tests#39196, web-platform-tests#39201, web-platform-tests#39227): ``` /infrastructure/server/webtransport-h3.https.sub.any.serviceworker.html TIMEOUT WebTransport server should be running and should handle a bidirectional stream - Test timed out TIMEOUT /infrastructure/server/webtransport-h3.https.sub.any.serviceworker.html /infrastructure/server/webtransport-h3.https.sub.any.worker.html TIMEOUT WebTransport server should be running and should handle a bidirectional stream - Test timed out TIMEOUT /infrastructure/server/webtransport-h3.https.sub.any.worker.html /infrastructure/server/webtransport-h3.https.sub.any.sharedworker.html TIMEOUT WebTransport server should be running and should handle a bidirectional stream - Test timed out TIMEOUT /infrastructure/server/webtransport-h3.https.sub.any.sharedworker.html /infrastructure/server/webtransport-h3.https.sub.any.html TIMEOUT WebTransport server should be running and should handle a bidirectional stream - Test timed out TIMEOUT /infrastructure/server/webtransport-h3.https.sub.any.html ``` Disable them for now. Also, remove the `.any.window.html` section, which is redundant with `.any.html`.
…latform-tests#39201) * [webtransport_h3_server] Support RFC version of HTTP Datagrams There is no significant semantics changes between draft04[1] and rfc[2]. * Capsule protocol was simlified. * HTTP Setting value has changed. [1] https://datatracker.ietf.org/doc/html/draft-ietf-masque-h3-datagram-04 [2] https://datatracker.ietf.org/doc/html/rfc9297
There is no significant semantics changes between draft04[1] and rfc[2].
[1] https://datatracker.ietf.org/doc/html/draft-ietf-masque-h3-datagram-04
[2] https://datatracker.ietf.org/doc/html/rfc9297