Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[webtransport_h3_server] Support RFC version of HTTP Datagrams #39201

Merged
merged 7 commits into from
Apr 4, 2023

Conversation

bashi
Copy link
Member

@bashi bashi commented Mar 25, 2023

There is no significant semantics changes between draft04[1] and rfc[2].

  • Capsule protocol was simlified.
  • HTTP Setting value has changed.

[1] https://datatracker.ietf.org/doc/html/draft-ietf-masque-h3-datagram-04
[2] https://datatracker.ietf.org/doc/html/rfc9297

bashi added 3 commits March 25, 2023 17:57
There is no significant semantics changes between draft04[1] and rfc[2].
* Capsule protocol was simlified.
* HTTP Setting value has changed.

[1]
https://datatracker.ietf.org/doc/html/draft-ietf-masque-h3-datagram-04
[2] https://datatracker.ietf.org/doc/html/rfc9297
@wpt-pr-bot
Copy link
Collaborator

There are no reviewers for this pull request besides its author. Please reach out on the chat room to get help with this. Thank you!

Copy link
Member

@nidhijaju nidhijaju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with nits :) Sorry for the delay!

"""
A H3Connection subclass, to make it work with the latest
HTTP Datagram protocol.
"""
H3_DATAGRAM_04 = 0xffd277
# https://datatracker.ietf.org/doc/html/draft-ietf-httpbis-h3-websockets-00#section-5
# https://datatracker.ietf.org/doc/html/rfc9220#name-iana-considerations
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Should this be https://datatracker.ietf.org/doc/html/rfc9220#section-5-2.2.1 to be more specific?

data=capsule.data, fin=fin)
else:
# Ignore unknown capsules.
pass
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be return to be consistent with line 195.

@bashi bashi closed this Mar 29, 2023
@bashi bashi reopened this Mar 29, 2023
@bashi bashi closed this Mar 29, 2023
@bashi bashi reopened this Mar 29, 2023
@bashi bashi closed this Mar 31, 2023
@bashi bashi reopened this Mar 31, 2023
@bashi
Copy link
Member Author

bashi commented Mar 31, 2023

@bashi bashi closed this Apr 1, 2023
@bashi bashi reopened this Apr 1, 2023
jonathan-j-lee added a commit to jonathan-j-lee/wpt that referenced this pull request Apr 3, 2023
These tests are timing out on Firefox macOS and blocking unrelated PRs
(e.g., web-platform-tests#39196, web-platform-tests#39201, web-platform-tests#39227):

```
/infrastructure/server/webtransport-h3.https.sub.any.serviceworker.html
  TIMEOUT WebTransport server should be running and should handle a bidirectional stream - Test timed out
  TIMEOUT /infrastructure/server/webtransport-h3.https.sub.any.serviceworker.html
/infrastructure/server/webtransport-h3.https.sub.any.worker.html
  TIMEOUT WebTransport server should be running and should handle a bidirectional stream - Test timed out
  TIMEOUT /infrastructure/server/webtransport-h3.https.sub.any.worker.html
/infrastructure/server/webtransport-h3.https.sub.any.sharedworker.html
  TIMEOUT WebTransport server should be running and should handle a bidirectional stream - Test timed out
  TIMEOUT /infrastructure/server/webtransport-h3.https.sub.any.sharedworker.html
/infrastructure/server/webtransport-h3.https.sub.any.html
  TIMEOUT WebTransport server should be running and should handle a bidirectional stream - Test timed out
  TIMEOUT /infrastructure/server/webtransport-h3.https.sub.any.html
```

Disable them for now. Also, remove the `.any.window.html` section, which
is redundant with `.any.html`.
jonathan-j-lee added a commit to jonathan-j-lee/wpt that referenced this pull request Apr 3, 2023
These tests are timing out on Firefox macOS and blocking unrelated PRs
(e.g., web-platform-tests#39196, web-platform-tests#39201, web-platform-tests#39227):

```
/infrastructure/server/webtransport-h3.https.sub.any.serviceworker.html
  TIMEOUT WebTransport server should be running and should handle a bidirectional stream - Test timed out
  TIMEOUT /infrastructure/server/webtransport-h3.https.sub.any.serviceworker.html
/infrastructure/server/webtransport-h3.https.sub.any.worker.html
  TIMEOUT WebTransport server should be running and should handle a bidirectional stream - Test timed out
  TIMEOUT /infrastructure/server/webtransport-h3.https.sub.any.worker.html
/infrastructure/server/webtransport-h3.https.sub.any.sharedworker.html
  TIMEOUT WebTransport server should be running and should handle a bidirectional stream - Test timed out
  TIMEOUT /infrastructure/server/webtransport-h3.https.sub.any.sharedworker.html
/infrastructure/server/webtransport-h3.https.sub.any.html
  TIMEOUT WebTransport server should be running and should handle a bidirectional stream - Test timed out
  TIMEOUT /infrastructure/server/webtransport-h3.https.sub.any.html
```

Disable them for now. Also, remove the `.any.window.html` section, which
is redundant with `.any.html`.
gsnedders pushed a commit that referenced this pull request Apr 4, 2023
These tests are timing out on Firefox macOS and blocking unrelated PRs
(e.g., #39196, #39201, #39227):

```
/infrastructure/server/webtransport-h3.https.sub.any.serviceworker.html
  TIMEOUT WebTransport server should be running and should handle a bidirectional stream - Test timed out
  TIMEOUT /infrastructure/server/webtransport-h3.https.sub.any.serviceworker.html
/infrastructure/server/webtransport-h3.https.sub.any.worker.html
  TIMEOUT WebTransport server should be running and should handle a bidirectional stream - Test timed out
  TIMEOUT /infrastructure/server/webtransport-h3.https.sub.any.worker.html
/infrastructure/server/webtransport-h3.https.sub.any.sharedworker.html
  TIMEOUT WebTransport server should be running and should handle a bidirectional stream - Test timed out
  TIMEOUT /infrastructure/server/webtransport-h3.https.sub.any.sharedworker.html
/infrastructure/server/webtransport-h3.https.sub.any.html
  TIMEOUT WebTransport server should be running and should handle a bidirectional stream - Test timed out
  TIMEOUT /infrastructure/server/webtransport-h3.https.sub.any.html
```

Disable them for now. Also, remove the `.any.window.html` section, which
is redundant with `.any.html`.
@bashi bashi closed this Apr 4, 2023
@bashi bashi reopened this Apr 4, 2023
@bashi bashi merged commit 72e0e0b into web-platform-tests:master Apr 4, 2023
@bashi bashi deleted the wt-h3datagram branch April 4, 2023 23:09
cookiecrook pushed a commit to cookiecrook/wpt that referenced this pull request Apr 8, 2023
These tests are timing out on Firefox macOS and blocking unrelated PRs
(e.g., web-platform-tests#39196, web-platform-tests#39201, web-platform-tests#39227):

```
/infrastructure/server/webtransport-h3.https.sub.any.serviceworker.html
  TIMEOUT WebTransport server should be running and should handle a bidirectional stream - Test timed out
  TIMEOUT /infrastructure/server/webtransport-h3.https.sub.any.serviceworker.html
/infrastructure/server/webtransport-h3.https.sub.any.worker.html
  TIMEOUT WebTransport server should be running and should handle a bidirectional stream - Test timed out
  TIMEOUT /infrastructure/server/webtransport-h3.https.sub.any.worker.html
/infrastructure/server/webtransport-h3.https.sub.any.sharedworker.html
  TIMEOUT WebTransport server should be running and should handle a bidirectional stream - Test timed out
  TIMEOUT /infrastructure/server/webtransport-h3.https.sub.any.sharedworker.html
/infrastructure/server/webtransport-h3.https.sub.any.html
  TIMEOUT WebTransport server should be running and should handle a bidirectional stream - Test timed out
  TIMEOUT /infrastructure/server/webtransport-h3.https.sub.any.html
```

Disable them for now. Also, remove the `.any.window.html` section, which
is redundant with `.any.html`.
cookiecrook pushed a commit to cookiecrook/wpt that referenced this pull request Apr 8, 2023
…latform-tests#39201)

* [webtransport_h3_server] Support RFC version of HTTP Datagrams

There is no significant semantics changes between draft04[1] and rfc[2].
* Capsule protocol was simlified.
* HTTP Setting value has changed.

[1]
https://datatracker.ietf.org/doc/html/draft-ietf-masque-h3-datagram-04
[2] https://datatracker.ietf.org/doc/html/rfc9297
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants