Add multitouch support to Gamepad API #39227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Mar 27, 2023
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3866373
branch
4 times, most recently
from
51ea560 to
251fe71
Compare
jonathan-j-lee
added a commit
to jonathan-j-lee/wpt
that referenced
this pull request
Apr 3, 2023
These tests are timing out on Firefox macOS and blocking unrelated PRs (e.g., web-platform-tests#39196, web-platform-tests#39201, web-platform-tests#39227): ``` /infrastructure/server/webtransport-h3.https.sub.any.serviceworker.html TIMEOUT WebTransport server should be running and should handle a bidirectional stream - Test timed out TIMEOUT /infrastructure/server/webtransport-h3.https.sub.any.serviceworker.html /infrastructure/server/webtransport-h3.https.sub.any.worker.html TIMEOUT WebTransport server should be running and should handle a bidirectional stream - Test timed out TIMEOUT /infrastructure/server/webtransport-h3.https.sub.any.worker.html /infrastructure/server/webtransport-h3.https.sub.any.sharedworker.html TIMEOUT WebTransport server should be running and should handle a bidirectional stream - Test timed out TIMEOUT /infrastructure/server/webtransport-h3.https.sub.any.sharedworker.html /infrastructure/server/webtransport-h3.https.sub.any.html TIMEOUT WebTransport server should be running and should handle a bidirectional stream - Test timed out TIMEOUT /infrastructure/server/webtransport-h3.https.sub.any.html ``` Disable them for now. Also, remove the `.any.window.html` section, which is redundant with `.any.html`.
jonathan-j-lee
added a commit
to jonathan-j-lee/wpt
that referenced
this pull request
Apr 3, 2023
These tests are timing out on Firefox macOS and blocking unrelated PRs (e.g., web-platform-tests#39196, web-platform-tests#39201, web-platform-tests#39227): ``` /infrastructure/server/webtransport-h3.https.sub.any.serviceworker.html TIMEOUT WebTransport server should be running and should handle a bidirectional stream - Test timed out TIMEOUT /infrastructure/server/webtransport-h3.https.sub.any.serviceworker.html /infrastructure/server/webtransport-h3.https.sub.any.worker.html TIMEOUT WebTransport server should be running and should handle a bidirectional stream - Test timed out TIMEOUT /infrastructure/server/webtransport-h3.https.sub.any.worker.html /infrastructure/server/webtransport-h3.https.sub.any.sharedworker.html TIMEOUT WebTransport server should be running and should handle a bidirectional stream - Test timed out TIMEOUT /infrastructure/server/webtransport-h3.https.sub.any.sharedworker.html /infrastructure/server/webtransport-h3.https.sub.any.html TIMEOUT WebTransport server should be running and should handle a bidirectional stream - Test timed out TIMEOUT /infrastructure/server/webtransport-h3.https.sub.any.html ``` Disable them for now. Also, remove the `.any.window.html` section, which is redundant with `.any.html`.
gsnedders
pushed a commit
that referenced
this pull request
Apr 4, 2023
These tests are timing out on Firefox macOS and blocking unrelated PRs (e.g., #39196, #39201, #39227): ``` /infrastructure/server/webtransport-h3.https.sub.any.serviceworker.html TIMEOUT WebTransport server should be running and should handle a bidirectional stream - Test timed out TIMEOUT /infrastructure/server/webtransport-h3.https.sub.any.serviceworker.html /infrastructure/server/webtransport-h3.https.sub.any.worker.html TIMEOUT WebTransport server should be running and should handle a bidirectional stream - Test timed out TIMEOUT /infrastructure/server/webtransport-h3.https.sub.any.worker.html /infrastructure/server/webtransport-h3.https.sub.any.sharedworker.html TIMEOUT WebTransport server should be running and should handle a bidirectional stream - Test timed out TIMEOUT /infrastructure/server/webtransport-h3.https.sub.any.sharedworker.html /infrastructure/server/webtransport-h3.https.sub.any.html TIMEOUT WebTransport server should be running and should handle a bidirectional stream - Test timed out TIMEOUT /infrastructure/server/webtransport-h3.https.sub.any.html ``` Disable them for now. Also, remove the `.any.window.html` section, which is redundant with `.any.html`.
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3866373
branch
from
251fe71 to
697d9ca
Compare
Changes and updates have been made to Fernando Attia's patchset 1612050. The implementation has been changed to support the most recent changes to the spec w3c/gamepad#168. Support for DualShock4 controller is part of patch. This commit is a squash of several changes the last major one is: Normalize touchIds per Gamepad The same hardware may provide input to Gamepads in different tabs. This commit normalizes touchIds coming from the hardware to a single incremented value starting at zero per Gamepad instance. Extend the Gamepad API to support multitouch surfaces (touchpads). Intent to prototype : https://groups.google.com/a/chromium.org/g/blink-dev/c/4q_k23rPMos Chrome status entry: https://www.chromestatus.com/feature/4782975812108288 [email protected] Change-Id: I0fa2006c3fc36a908b316cc29b97d295aac798ca Update idl to match current spec draft Normalize touchid to 32bit value. Update web tests. Bug: 1143942 Change-Id: I80ed31ebf0c6a347906b91b3c178099d1e332c53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3866373 Reviewed-by: Matt Reynolds <[email protected]> Commit-Queue: Matt Reynolds <[email protected]> Cr-Commit-Position: refs/heads/main@{#1126297}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3866373
branch
from
697d9ca to
3eaed2e
Compare
cookiecrook
pushed a commit
to cookiecrook/wpt
that referenced
this pull request
Apr 8, 2023
These tests are timing out on Firefox macOS and blocking unrelated PRs (e.g., web-platform-tests#39196, web-platform-tests#39201, web-platform-tests#39227): ``` /infrastructure/server/webtransport-h3.https.sub.any.serviceworker.html TIMEOUT WebTransport server should be running and should handle a bidirectional stream - Test timed out TIMEOUT /infrastructure/server/webtransport-h3.https.sub.any.serviceworker.html /infrastructure/server/webtransport-h3.https.sub.any.worker.html TIMEOUT WebTransport server should be running and should handle a bidirectional stream - Test timed out TIMEOUT /infrastructure/server/webtransport-h3.https.sub.any.worker.html /infrastructure/server/webtransport-h3.https.sub.any.sharedworker.html TIMEOUT WebTransport server should be running and should handle a bidirectional stream - Test timed out TIMEOUT /infrastructure/server/webtransport-h3.https.sub.any.sharedworker.html /infrastructure/server/webtransport-h3.https.sub.any.html TIMEOUT WebTransport server should be running and should handle a bidirectional stream - Test timed out TIMEOUT /infrastructure/server/webtransport-h3.https.sub.any.html ``` Disable them for now. Also, remove the `.any.window.html` section, which is redundant with `.any.html`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes and updates have been made to Fernando Attia's patchset 1612050.
The implementation has been changed to support the most recent changes
to the spec w3c/gamepad#168.
Support for DualShock4 controller is part of patch.
This commit is a squash of several changes the last major one is:
Normalize touchIds per Gamepad
The same hardware may provide input to Gamepads in different tabs.
This commit normalizes touchIds coming from the hardware to a single
incremented value starting at zero per Gamepad instance.
Extend the Gamepad API to support multitouch surfaces (touchpads).
Intent to prototype :
https://groups.google.com/a/chromium.org/g/blink-dev/c/4q_k23rPMos
Chrome status entry:
https://www.chromestatus.com/feature/4782975812108288
R=[email protected]
Change-Id: I0fa2006c3fc36a908b316cc29b97d295aac798ca
Update idl to match current spec draft
Normalize touchid to 32bit value.
Update web tests.
Bug: 1143942
Change-Id: I80ed31ebf0c6a347906b91b3c178099d1e332c53
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3866373
Reviewed-by: Matt Reynolds <[email protected]>
Commit-Queue: Matt Reynolds <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1126297}