Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add debug_accountRangeAt/debug_storageRangeAt methods #1799

Merged
merged 2 commits into from
Aug 8, 2018

Conversation

axic
Copy link
Contributor

@axic axic commented Jul 26, 2018

These are needed for the ewasm testnet blockexplorer.

cc @cdetrio

@frozeman
Copy link
Contributor

frozeman commented Aug 8, 2018

I dont think they should be part of the main web3.js lib, as they are node specific, but you can simply attach them later by using the extend function in your code: https://web3js.readthedocs.io/en/1.0/web3.html#extend

We can have a chat about that in skype if you like.

@axic
Copy link
Contributor Author

axic commented Aug 8, 2018

Actually I don't think these are designed to be client specific (I agree the parity ones are).

These supposed to be standard tracing methods, used by Remix and all the frameworks for debugging.

Btw, can you quickly explain the rules of inclusion? Would it be possible to have these here as a separate module (optionally loaded)? Or what is the best way to supply a distribution of these?

@frozeman
Copy link
Contributor

frozeman commented Aug 8, 2018

If they are supported in all/most nodes we can surely include them.
You could always make a separate package that runs web3.extend().. before and adds it to the running web3.js. Ill merge this if its widely used. We should discuss adding this to 1.0 as well.

@frozeman frozeman merged commit 822cf8d into web3:develop Aug 8, 2018
@axic
Copy link
Contributor Author

axic commented Aug 18, 2018

Does extend only works on the instance and not on the package?

@axic axic deleted the debug-methods branch August 18, 2018 00:27
@axic
Copy link
Contributor Author

axic commented Aug 18, 2018

@frozeman can you have a look at https://github.com/axic/web3-extended.js if this is the way you've suggested?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants