Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Parity trace_*/parity_* methods #1801

Closed
wants to merge 3 commits into from
Closed

Conversation

axic
Copy link
Contributor

@axic axic commented Jul 26, 2018

These are commits from https://github.com/gobitfly/web3.js made by @ppratscher and @digithinksa.

These are used by https://github.com/gobitfly/etherchain-light and we are trying to use it for the ewasm testnet (fork: https://github.com/ewasm/etherchain-light).

cc @cdetrio

@frozeman
Copy link
Contributor

frozeman commented Aug 8, 2018

I dont think they should be part of the main web3.js lib, as they are node specific, but you can simply attach them later by using the extend function in your code: https://web3js.readthedocs.io/en/1.0/web3.html#extend

We can have a chat about that in skype if you like.

@nivida
Copy link
Contributor

nivida commented Nov 28, 2018

Awesome thanks! Sorry for bothering you after that long time but could you add these methods to the ethereumProvider branch? It should be really easy to add them (see web3-core-method/models/methods). I think it would be good to add these methods as a debug module, writing a simple documentation about and to declare them as node specific (Parity).

The readme of web3-core & web3-core-method will help you to implement a new module.

@nivida
Copy link
Contributor

nivida commented Jan 21, 2019

0.20.x will not get any new features because of the maintenance mode. Didn't see that this PR belongs to v0.20.x.
If you would like to create a module for the debug methods then please check out the new possibilities the 1.0.0-beta.38 release will give you for creating such a module:
https://github.com/ethereum/web3-examples/tree/development/modules

Or create a feature request issue and I will implement it later. :-)

Because of that I will close this PR.

@nivida nivida closed this Jan 21, 2019
@axic
Copy link
Contributor Author

axic commented Jan 21, 2019

See my comment here: #1799 (comment)

I have actually moved both my PRs into a module.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants