Skip to content
This repository has been archived by the owner on Mar 5, 2025. It is now read-only.

Contract call with tuple is missing param names #5613

Merged
merged 14 commits into from
Nov 30, 2022
Merged

Contract call with tuple is missing param names #5613

Changes from 2 commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
adc3704
call special output type
avkos Nov 14, 2022
c91e518
fix
avkos Nov 14, 2022
a22f2a2
fix: enable outputs to have param names (#5624)
mpetrunic Nov 17, 2022
a338132
hot fix
avkos Nov 22, 2022
09283a7
add type if only one param
avkos Nov 22, 2022
0f81c97
overloaded inputs types
avkos Nov 22, 2022
d69c0e5
fix resolver tests
avkos Nov 23, 2022
d88fd45
add type tests
avkos Nov 24, 2022
294d7b6
simplify types
avkos Nov 24, 2022
9c28a4b
revert registry unit test
avkos Nov 24, 2022
fb00514
test firefox
avkos Nov 25, 2022
924da4c
revert firefox test
avkos Nov 25, 2022
2120e37
Merge branch '4.x' into ok/5504-Contract-call-with-tuple-is-missing-p…
avkos Nov 28, 2022
d1dd37a
update changelogs
avkos Nov 30, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions packages/web3-eth-contract/src/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,7 +227,11 @@ export interface NonPayableMethodObject<Inputs = unknown[], Outputs = unknown[]>
* @param block - If you pass this parameter it will not use the default block set with contract.defaultBlock. Pre-defined block numbers as `earliest`, `latest`, and `pending` can also be used. Useful for requesting data from or replaying transactions in past blocks.
* @returns - The return value(s) of the smart contract method. If it returns a single value, it’s returned as is. If it has multiple return values they are returned as an object with properties and indices.
*/
call(tx?: NonPayableCallOptions, block?: BlockNumberOrTag): Promise<Outputs>;

call<SpecialOutput = Outputs>(
tx?: NonPayableCallOptions,
block?: BlockNumberOrTag,
): Promise<SpecialOutput>;

/**
* This will send a transaction to the smart contract and execute its method. Note this can alter the smart contract state.
Expand Down Expand Up @@ -384,7 +388,10 @@ export interface PayableMethodObject<Inputs = unknown[], Outputs = unknown[]> {
* @param block - If you pass this parameter it will not use the default block set with contract.defaultBlock. Pre-defined block numbers as `earliest`, `latest`, and `pending` can also be used. Useful for requesting data from or replaying transactions in past blocks.
* @returns - The return value(s) of the smart contract method. If it returns a single value, it’s returned as is. If it has multiple return values they are returned as an object with properties and indices.
*/
call(tx?: PayableCallOptions, block?: BlockNumberOrTag): Promise<Outputs>;
call<SpecialOutput = Outputs>(
tx?: PayableCallOptions,
block?: BlockNumberOrTag,
): Promise<SpecialOutput>;

/**
* Will send a transaction to the smart contract and execute its method. Note this can alter the smart contract state.
Expand Down