Contract call with tuple is missing param names #5613

avkos · 2022-11-14T01:34:45Z

Description

Checklist for 4.x:

render · 2022-11-14T01:34:50Z

Your Render PR Server URL is https://atweb3js-docs-pr-5613.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-cdopmdpgp3jou2cjj8lg.

mpetrunic

This works sort of, I was hoping you would solve this: https://github.com/web3/web3.js/blob/4.x/packages/web3-eth-abi/src/types.ts#L193 😜

packages/web3-eth-contract/src/types.ts

avkos · 2022-11-14T17:03:46Z

This works sort of, I was hoping you would solve this: https://github.com/web3/web3.js/blob/4.x/packages/web3-eth-abi/src/types.ts#L193 😜

I've tried to figure it out but seems typescript not supporting dynamic names for the tuples right now.

mpetrunic · 2022-11-16T11:40:07Z

@avkos Here is an idea #5624 ^^

avkos · 2022-11-17T15:27:03Z

@avkos Here is an idea #5624 ^^

Thanks a lot. I'll investigate it.

jdevcs

Its causing many tests to fail in https://github.com/web3/web3.js/actions/runs/3490219406/jobs/5841458348#step:4:176 all these tests should be passing before merging PR.

Tests are not passing

mpetrunic · 2022-11-21T09:02:06Z

Its causing many tests to fail in https://github.com/web3/web3.js/actions/runs/3490219406/jobs/5841458348#step:4:176 all these tests should be passing before merging PR.

Even though types should be fixed to support that, it makes more sense to use output param name instead of array index in those tests as it's much more type safer.

It might make sense to introduce type only tests for web3-eth-abi package: https://medium.com/front-end-weekly/testing-typescript-types-1595c641d7c7^^

mpetrunic · 2022-11-22T12:04:41Z

@avkos #5647 adds type tests and support for single output tuple

avkos · 2022-11-22T15:05:43Z

add the possibility to see types in the output types

if single output returns exactly one type

for overloaded functions shows all variants of input parameters

mpetrunic · 2022-11-23T09:05:09Z

add the possibility to see types in the output types

if single output returns exactly one type

for overloaded functions shows all variants of input parameters

Think you should check my PR as I've extended tests so you can cover all this cases with tests to make sure everything works^^

avkos · 2022-11-24T22:38:30Z

I've fixed the types. Now they work in both ways by index and by name. Also, type tests were added. @mpetrunic

mpetrunic · 2022-11-25T12:52:42Z

I've fixed the types. Now they work in both ways by index and by name. Also, type tests were added. @mpetrunic

@jdevcs @mconnelly8 Would it make sense to open an issue to create a guide for users explaining how to extract result types from abi (as they will probably need to do something with the result)? Like type GetBalanceResult = SomethingSomething<typeof abi[1]>

…aram-names

spacesailor24

Please add CHANGELOG.md entries (for root, web3-eth-abi, and web3-eth-contract)

avkos · 2022-11-30T02:31:57Z

Please add CHANGELOG.md entries (for root, web3-eth-abi, and web3-eth-contract)

Changelogs were added

* Update CHANGELOG version headers * Contract call with tuple is missing param names (#5613) * call special output type * fix * fix: enable outputs to have param names (#5624) * hot fix * add type if only one param * overloaded inputs types * fix resolver tests * add type tests * simplify types * revert registry unit test * test firefox * revert firefox test * update changelogs Co-authored-by: Marin Petrunić <[email protected]> * Fix `isHex` and `isHexStrict` for some edge cases and enrich their tests (#5655) * Change `isHex` to return true for negative numbers (for example `-123`) * Change both `isHex` and `isHexStrict` to return `false` for `-0x` * Change `isHex` to return `false` for empty strings ''. * Remove erroneous set provider code for Contract constructor (#5669) * Remove erroneous set provider code for Contract constructor. Add Contract constructor provider set test * Update CHANGELOGs * Debugging failing integration tests * Apply suggestions from code review * Use getSystemTestProvider instead of hardcoded string * Refactor ternaries in Contract constructor to if statements * Correct CHANGELOG entries * Remove unneeded checks in if statements * Test with injected external providers (#5652) * fix: sending tx with injected provider (#5651) Co-authored-by: Marin Petrunic <[email protected]> * adding a test for using `ganache` provider * enable the jsonrpc `id` to optionally be incremented starting from a number (Inspired by: #5373 (comment) and needed as a work around for blockchainsllc/in3#46) * test with `in3` as a provider & skip `in3` test if it takes too long * increase integration test timeout at web3 package * add a test for using `hardhat` provider * improve how legacy providers, such as hardhat, is used * implement `isPromise` that works in the browsers * refactor external providers tests * update CHANGELOG.md * Use Error ABI to parse errors when sending a transaction (#5662) * use Error ABI when sending a transaction * update CHANGELOG.md for #5587 * Remove merge conflict marker Co-authored-by: Oleksii Kosynskyi <[email protected]> Co-authored-by: Marin Petrunić <[email protected]> Co-authored-by: Muhammad Altabba <[email protected]> Co-authored-by: jdevcs <[email protected]>

* Version bump and build for v4.0.1-alpha.2 * Release/4.0.1 alpha.2 changelog update 3 (#5689) * Update CHANGELOG version headers * Update CHANGELOGs * Revert package version bump for web3-packagetemplate * Release/4.0.1 alpha.2 merge conflicts (#5692) * Update CHANGELOG version headers * Contract call with tuple is missing param names (#5613) * call special output type * fix * fix: enable outputs to have param names (#5624) * hot fix * add type if only one param * overloaded inputs types * fix resolver tests * add type tests * simplify types * revert registry unit test * test firefox * revert firefox test * update changelogs Co-authored-by: Marin Petrunić <[email protected]> * Fix `isHex` and `isHexStrict` for some edge cases and enrich their tests (#5655) * Change `isHex` to return true for negative numbers (for example `-123`) * Change both `isHex` and `isHexStrict` to return `false` for `-0x` * Change `isHex` to return `false` for empty strings ''. * Remove erroneous set provider code for Contract constructor (#5669) * Remove erroneous set provider code for Contract constructor. Add Contract constructor provider set test * Update CHANGELOGs * Debugging failing integration tests * Apply suggestions from code review * Use getSystemTestProvider instead of hardcoded string * Refactor ternaries in Contract constructor to if statements * Correct CHANGELOG entries * Remove unneeded checks in if statements * Test with injected external providers (#5652) * fix: sending tx with injected provider (#5651) Co-authored-by: Marin Petrunic <[email protected]> * adding a test for using `ganache` provider * enable the jsonrpc `id` to optionally be incremented starting from a number (Inspired by: #5373 (comment) and needed as a work around for blockchainsllc/in3#46) * test with `in3` as a provider & skip `in3` test if it takes too long * increase integration test timeout at web3 package * add a test for using `hardhat` provider * improve how legacy providers, such as hardhat, is used * implement `isPromise` that works in the browsers * refactor external providers tests * update CHANGELOG.md * Use Error ABI to parse errors when sending a transaction (#5662) * use Error ABI when sending a transaction * update CHANGELOG.md for #5587 * Remove merge conflict marker Co-authored-by: Oleksii Kosynskyi <[email protected]> Co-authored-by: Marin Petrunić <[email protected]> Co-authored-by: Muhammad Altabba <[email protected]> Co-authored-by: jdevcs <[email protected]> * Release patch/4.0.1 alpha.2/solve merge conflicts (#5697) * Update CHANGELOG version headers * Remove merge conflict markers * Remove double CHANGELOG entry Co-authored-by: Oleksii Kosynskyi <[email protected]> Co-authored-by: Marin Petrunić <[email protected]> Co-authored-by: Muhammad Altabba <[email protected]> Co-authored-by: jdevcs <[email protected]>

call special output type

adc3704

avkos requested review from jdevcs, luu-alex, Muhammad-Altabba, nikoulai and spacesailor24 November 14, 2022 16:42

mpetrunic reviewed Nov 14, 2022

View reviewed changes

packages/web3-eth-contract/src/types.ts Outdated Show resolved Hide resolved

fix

c91e518

avkos requested a review from mpetrunic November 14, 2022 17:13

Muhammad-Altabba previously approved these changes Nov 16, 2022

View reviewed changes

nikoulai approved these changes Nov 16, 2022

View reviewed changes

fix: enable outputs to have param names (#5624)

a22f2a2

jdevcs reviewed Nov 17, 2022

View reviewed changes

Muhammad-Altabba self-requested a review November 20, 2022 21:30

avkos added 3 commits November 21, 2022 19:11

hot fix

a338132

add type if only one param

09283a7

overloaded inputs types

0f81c97

fix resolver tests

d69c0e5

add type tests

d88fd45

avkos requested a review from jdevcs November 24, 2022 22:38

avkos added 3 commits November 24, 2022 18:04

simplify types

294d7b6

revert registry unit test

9c28a4b

test firefox

fb00514

avkos added 2 commits November 25, 2022 10:18

revert firefox test

924da4c

Merge branch '4.x' into ok/5504-Contract-call-with-tuple-is-missing-p…

2120e37

…aram-names

spacesailor24 suggested changes Nov 29, 2022

View reviewed changes

update changelogs

d1dd37a

avkos requested a review from spacesailor24 November 30, 2022 02:31

spacesailor24 approved these changes Nov 30, 2022

View reviewed changes

avkos merged commit 19269ae into 4.x Nov 30, 2022

avkos deleted the ok/5504-Contract-call-with-tuple-is-missing-param-names branch November 30, 2022 03:29

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Contract call with tuple is missing param names #5613

Contract call with tuple is missing param names #5613

avkos commented Nov 14, 2022

render bot commented Nov 14, 2022

mpetrunic left a comment

avkos commented Nov 14, 2022

mpetrunic commented Nov 16, 2022

avkos commented Nov 17, 2022

jdevcs left a comment

mpetrunic commented Nov 21, 2022

mpetrunic commented Nov 22, 2022

avkos commented Nov 22, 2022

mpetrunic commented Nov 23, 2022

avkos commented Nov 24, 2022

mpetrunic commented Nov 25, 2022

spacesailor24 left a comment

avkos commented Nov 30, 2022

Contract call with tuple is missing param names #5613

Contract call with tuple is missing param names #5613

Conversation

avkos commented Nov 14, 2022

Description

Checklist for 4.x:

render bot commented Nov 14, 2022

mpetrunic left a comment

Choose a reason for hiding this comment

avkos commented Nov 14, 2022

mpetrunic commented Nov 16, 2022

avkos commented Nov 17, 2022

jdevcs left a comment

Choose a reason for hiding this comment

mpetrunic commented Nov 21, 2022

mpetrunic commented Nov 22, 2022

avkos commented Nov 22, 2022

mpetrunic commented Nov 23, 2022

avkos commented Nov 24, 2022

mpetrunic commented Nov 25, 2022

spacesailor24 left a comment

Choose a reason for hiding this comment

avkos commented Nov 30, 2022