This repository has been archived by the owner on Dec 5, 2019. It is now read-only.
fix(package): mv uglify2 to dependencies && update peerDependencies
#45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o add webpack 3 to peerDependencies.
michael-ciniawsky
changed the title
dependencies && update peerDependencies
michael-ciniawsky
requested review from
bebraw,
alexander-akait,
joshwiens and
TheLarkInn
michael-ciniawsky
approved these changes
Jun 19, 2017
|
@jharris4 Thx |
michael-ciniawsky
added
pr_action: Merge ready
status: Approved
and removed
pr_action: Review
labels
michael-ciniawsky
pushed a commit
that referenced
this pull request
Jun 28, 2017
michael-ciniawsky
pushed a commit
that referenced
this pull request
Jun 28, 2017
michael-ciniawsky
pushed a commit
that referenced
this pull request
Jun 28, 2017
TheLarkInn
pushed a commit
that referenced
this pull request
Jun 29, 2017
* fix(package): mv uglify2 to `dependencies` && update `peerDependencies` (#45) * refactor: apply to `webpack-defaults` * chore(package): update `webpack-defaults v1.0.1...1.4.0` * refactor(package): rm `pre-push` hook * chore: rm `yarn.lock` * fix(index): linting
hulkish
pushed a commit
to hulkish/uglifyjs-webpack-plugin
that referenced
this pull request
Jun 29, 2017
joshwiens
pushed a commit
that referenced
this pull request
Jun 29, 2017
* fix(package): mv uglify2 to `dependencies` && update `peerDependencies` (#45) * refactor: apply to `webpack-defaults` * chore(package): update `webpack-defaults v1.0.1...1.4.0` * chore: rm `yarn.lock` * ported uglifyjs unit tests from webpack core repo
joshwiens
pushed a commit
that referenced
this pull request
Jun 29, 2017
joshwiens
pushed a commit
that referenced
this pull request
Jun 29, 2017
* fix(package): mv uglify2 to `dependencies` && update `peerDependencies` (#45) * refactor: apply to `webpack-defaults` * chore(package): update `webpack-defaults v1.0.1...1.4.0` * refactor(package): rm `pre-push` hook * chore: rm `yarn.lock` * fix(index): linting
joshwiens
pushed a commit
that referenced
this pull request
Jun 29, 2017
* fix(package): mv uglify2 to `dependencies` && update `peerDependencies` (#45) * refactor: apply to `webpack-defaults` * chore(package): update `webpack-defaults v1.0.1...1.4.0` * chore: rm `yarn.lock` * ported uglifyjs unit tests from webpack core repo
joshwiens
pushed a commit
that referenced
this pull request
Jun 29, 2017
* fix(package): mv uglify2 to `dependencies` && update `peerDependencies` (#45) * refactor: apply to `webpack-defaults` * chore(package): update `webpack-defaults v1.0.1...1.4.0` BREAKING CHANGE: Enforces `peerDependencies` of `"webpack": ">= 3.0.0-rc.0 || ^3.0.0"`. BREAKING CHANGE: Enforces `engines` of `"node": ">=4.3.0 < 5.0.0 || >= 5.10`
joshwiens
pushed a commit
that referenced
this pull request
Jun 29, 2017
* fix(package): mv uglify2 to `dependencies` && update `peerDependencies` (#45) * refactor: apply to `webpack-defaults` * chore(package): update `webpack-defaults v1.0.1...1.4.0` * chore: rm `yarn.lock` * ported uglifyjs unit tests from webpack core repo
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also add webpack 3 to peerDependencies.
Should fix #44