This repository has been archived by the owner on Dec 5, 2019. It is now read-only.
test: add && backport tests from webpack core #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added eslint-plugin-jest for tests, upgraded jest, babel-jest & webpack dev deps cleanup, corrected snapshot test fixed linting errors added eslintignore for test stubs corrected eslintignore paths added codecov config fixing codecov corrected jest test/src/coverage paths removed coverageDirectory: './coverage/' from jest config since it's default separated snapshot tests made createCompiler options replaceable, improved default options test separated tests by logic into separate test files improved snapshot tests cleaned up stacktraces in snapshot output, to allow snapshots to not fail just because paths change in error stack fix typo cleaned up test compilation error stacks to be more generic more cleanup
TheLarkInn
approved these changes
Jun 29, 2017
michael-ciniawsky
changed the title
michael-ciniawsky
approved these changes
Jun 29, 2017
michael-ciniawsky
changed the title
|
|
|
https://github.com/webpack-contrib/uglifyjs-webpack-plugin/blob/master/package.json#L21 - --runInBand(but likely not, super awkward 😛 ) |
joshwiens
pushed a commit
that referenced
this pull request
Jun 29, 2017
* fix(package): mv uglify2 to `dependencies` && update `peerDependencies` (#45) * refactor: apply to `webpack-defaults` * chore(package): update `webpack-defaults v1.0.1...1.4.0` * chore: rm `yarn.lock` * ported uglifyjs unit tests from webpack core repo
joshwiens
pushed a commit
that referenced
this pull request
Jun 29, 2017
* fix(package): mv uglify2 to `dependencies` && update `peerDependencies` (#45) * refactor: apply to `webpack-defaults` * chore(package): update `webpack-defaults v1.0.1...1.4.0` * chore: rm `yarn.lock` * ported uglifyjs unit tests from webpack core repo
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebased to master version of #56 version