test: delete temp directory #1958
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, main.css doesn't delete after running tests and it causes the errors of prettier.
hiroppy
commented
Jun 4, 2019
| @@ -40,11 +40,11 @@ describe('SockJSServer', () => { | |||
|
|
|||
| const client = new SockJS('http://localhost:8080/sockjs-node'); | |||
|
|
|||
| client.onmessage = function(e) { | |||
| client.onmessage = (e) => { | |||
There was a problem hiding this comment.
warning Unexpected unnamed function func-names
| data.push(e.data); | ||
| }; | ||
|
|
||
| client.onclose = function() { | ||
| client.onclose = () => { |
There was a problem hiding this comment.
warning Unexpected unnamed function func-names
Codecov Report
@@ Coverage Diff @@
## master #1958 +/- ##
=======================================
Coverage 92.58% 92.58%
=======================================
Files 27 27
Lines 985 985
Branches 307 307
=======================================
Hits 912 912
Misses 70 70
Partials 3 3Continue to review full report at Codecov.
|
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Bugs and Features; did you add new tests?
modify only
Motivation / Use-Case
Currently, main.css doesn't delete after running tests and it causes the errors of prettier.
In addition, we don't need
tempdirectory. If you want it, you can usefs.mkdtemp.Breaking Changes
no
Additional Info