Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: delete temp directory #1958

Merged
merged 1 commit into from
Jun 4, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -14,4 +14,4 @@ node_modules

.eslintcache

test/temp/*.css
test/fixtures/reload-config/main.css
4 changes: 2 additions & 2 deletions test/SockJSServer.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -40,11 +40,11 @@ describe('SockJSServer', () => {

const client = new SockJS('http://localhost:8080/sockjs-node');

client.onmessage = function(e) {
client.onmessage = (e) => {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning Unexpected unnamed function func-names

data.push(e.data);
};

client.onclose = function() {
client.onclose = () => {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning Unexpected unnamed function func-names

data.push('close');
};

Expand Down
8 changes: 5 additions & 3 deletions test/e2e/Client.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,14 +4,15 @@
no-undef
*/
const fs = require('fs');
const path = require('path');
const { resolve } = require('path');
const testServer = require('../helpers/test-server');
const reloadConfig = require('../fixtures/reload-config/webpack.config');
const runBrowser = require('../helpers/run-browser');

const cssFilePath = resolve(__dirname, '../fixtures/reload-config/main.css');

describe('reload', () => {
describe('hot', () => {
const cssFilePath = path.resolve(__dirname, '../temp/main.css');
beforeAll((done) => {
fs.writeFileSync(
cssFilePath,
Expand All @@ -30,6 +31,7 @@ describe('reload', () => {
});

afterAll((done) => {
fs.unlinkSync(cssFilePath);
testServer.close(done);
});

Expand Down Expand Up @@ -91,7 +93,6 @@ describe('reload', () => {
});

describe('inline', () => {
const cssFilePath = path.resolve(__dirname, '../temp/main.css');
beforeAll((done) => {
fs.writeFileSync(
cssFilePath,
Expand All @@ -110,6 +111,7 @@ describe('reload', () => {
});

afterAll((done) => {
fs.unlinkSync(cssFilePath);
testServer.close(done);
});

Expand Down
2 changes: 1 addition & 1 deletion test/fixtures/reload-config/foo.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
'use strict';

// eslint-disable-next-line import/no-unresolved
require('../../temp/main.css');
require('./main.css');
1 change: 0 additions & 1 deletion test/temp/README.md

This file was deleted.