Fix Elasticsearch NGINX stub #464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mischabraam Hi, why hasn't this been tagged in a new minor release? It broke my fresh install this morning when pulling in version 2.0.0. I literally have a wiki of valet-plus issues compiled and the fixes for them, this one was about to get added. Could we get more consistent releases for fixes like this please? all this needed was a 2.0.1 and I wouldn't have encountered the issue this morning. Thanks. |
|
@clnt If you follow the contribution guidelines I would love to merge all your PR's. And as we get more PR's we can more often release smaller updates. |
mischabraam
pushed a commit
that referenced
this pull request
Nov 25, 2020
* Update PULL_REQUEST_TEMPLATE.md with correct format Updated the format to reflect the correct questions to be asked for a PR. * Update readme.md * Update readme.md * Update readme.md * Update readme.md * Fix Elasticsearch NGINX stub (#464) * Update readme.md * Moved contributors to their own section. * [TASK] Applied nginx changes based on Magento 2 Example NGINX https://github.com/magento/magento2/blame/2.4-develop/nginx.conf.sample#L184 Co-authored-by: Lou van der Laarse <[email protected]> Co-authored-by: Frank Houtappels <[email protected]> Co-authored-by: Sam Granger <[email protected]> Co-authored-by: Mischa Braam <[email protected]> Co-authored-by: Sander <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have read the contribution guidelines and am targeting the branch
<YOUR_TARGET_BRANCH>:Because this is a Bug Fix which is Backwards Compatible.
Because this is a Feature which is not Backwards Compatible.
Because this is a Deprecation which is Backwards Compatible.
etc...
Changed