Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TASK] Applied nginx changes based on Magento 2 Example NGINX #517

Merged
merged 9 commits into from
Nov 25, 2020
Merged

[TASK] Applied nginx changes based on Magento 2 Example NGINX #517

merged 9 commits into from
Nov 25, 2020

Conversation

lewisvoncken
Copy link
Contributor

@lewisvoncken lewisvoncken commented Jul 30, 2020 •
edited
Loading

https://github.com/magento/magento2/blame/2.4-develop/nginx.conf.sample#L184

  • There is an issue ticket which accompanies my PR: .
  • I have followed the guidelines for contributing.
  • I have checked that there aren't other open pull requests for the same issue ticket.
  • I have formatted my code with the PSR-2 coding style before submitting my PR.

I have read the contribution guidelines and am targeting the branch 2.X:
Because this is a Bug Fix which is Backwards Compatible.

@lewisvoncken lewisvoncken changed the base branch from master to 2.x July 30, 2020 08:34
@mischabraam mischabraam merged commit ac909db into weprovide:2.x Nov 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lewisvoncken @mischabraam @Neodork @samgranger @SanderAtom