Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] assign correct YML version compatibility to PHP 7.0 - Moving changes to branch 2.x #541

Merged
merged 3 commits into from
Oct 3, 2020

Conversation

amarroni
Copy link
Contributor

@amarroni amarroni commented Oct 2, 2020

Per @Neodork comment I move all the changes to branch 2.x

@amarroni amarroni changed the title Moving changes to branch 2.x [FIX] assign correct YML version compatibility to PHP 7.0 - Moving changes to branch 2.x Oct 2, 2020
@Neodork
Copy link
Collaborator

Neodork commented Oct 3, 2020


I have read the contribution guidelines and am targeting the branch <YOUR_TARGET_BRANCH>:
Because this is a Bug Fix which is Backwards Compatible.

Changelog entry:
Short description of your work as explained by: Keep A Changelog.

  • Fixed PECL YML package no longer supporting PHP 7.0 beyond version 2.0.4.

@Neodork
Copy link
Collaborator

Neodork commented Oct 3, 2020

Hey @amarroni! First of all thank you for your quick response I really appreciate that. This issue was blocking and it would feel unfair to me to take away your credits after you've provided us with a PR.

Your provided PR is all green! We can merge this and it will be added to the next release of valet-plus.

@Neodork Neodork merged commit 14519b1 into weprovide:2.x Oct 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants