[FIX] assign correct YML version compatibility to PHP 7.0 #505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated the format to reflect the correct questions to be asked for a PR.
Neodork
added
2.x
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@amarroni Would you mind rebasing your branch from |
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
#541 DONE! |
|
@amarroni Thanks for the effort! Your work is merged and will be included in the next release. I really appreciate the quick response on my request. Thanks again. You can check your work here: https://github.com/weprovide/valet-plus/commits/2.x |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
YAML version minimal compatibility changed to PHP 7.1.0, was needed to determine the YAML version will working without problems.
Based on discussion on Channel Slack, the version is 2.0.4 (provide @Neodork thank you.)
Added. that version to 7.0 -> 2.0.4