-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update metamask sdk and improve chain switching with metamask mobile #4422
Conversation
🦋 Changeset detectedLatest commit: fae63a6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Size Change: +22.7 kB (+2.85%) Total Size: 820 kB
ℹ️ View Unchanged
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4422 +/- ##
==========================================
- Coverage 94.03% 85.72% -8.32%
==========================================
Files 278 271 -7
Lines 7147 6957 -190
Branches 827 700 -127
==========================================
- Hits 6721 5964 -757
- Misses 412 977 +565
- Partials 14 16 +2 ☔ View full report in Codecov by Sentry. |
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
|
This PR aims to solve an issue where the original logic of switchChain -> add if it's not present would cause an extra back and forth between dapp and the MetaMask wallet, particularly on Mobile to Mobile interactions.