Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use a single exception for name validation (follow up) #675

Closed
wants to merge 1 commit into from
Closed

Use a single exception for name validation (follow up) #675

wants to merge 1 commit into from

Conversation

cscott
Copy link

@cscott cscott commented Aug 8, 2018 •
edited by pr-preview bot
Loading

This addresses two cases overlooked by 61f40b0:

  • The QName production is a strict subset of the Name production. To avoid confusion, drop "or Name" from the definition of "validate a qualifiedName".
  • The non-normative "for web developers" text for createElementNS was not updated by the original commit.

Fixes: #671

💥 Error: 500 Internal Server Error 💥

PR Preview failed to build. (Last tried on Jan 15, 2021, 7:33 AM UTC).

More

PR Preview relies on a number of web services to run. There seems to be an issue with the following one:

🚨 CSS Spec Preprocessor - CSS Spec Preprocessor is the web service used to build Bikeshed specs.

🔗 Related URL

<!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML 2.0//EN">
<html><head>
<title>500 Internal Server Error</title>
</head><body>
<h1>Internal Server Error</h1>
<p>The server encountered an internal error or
misconfiguration and was unable to complete
your request.</p>
<p>Please contact the server administrator at 
 [no address given] to inform them of the time this error occurred,
 and the actions you performed just before this error.</p>
<p>More information about this error may be available
in the server error log.</p>
<hr>
<address>Apache/2.4.10 (Debian) Server at api.csswg.org Port 443</address>
</body></html>

If you don't have enough information above to solve the error by yourself (or to understand to which web service the error is related to, if any), please file an issue.

@cscott
Use a single exception for name validation (follow up)
7ad34f3 
This addresses two cases overlooked by 61f40b0:

* The QName production is a strict subset of the Name production.  To
  avoid confusion, drop "or Name" from the definition of "validate
  a qualifiedName".

* The non-normative "for web developers" text for `createElementNS`
  was not updated by the original commit.

Fixes: whatwg#671
@cscott cscott mentioned this pull request Aug 8, 2018
Closed
@annevk
Copy link
Member

annevk commented Aug 9, 2018

Thanks @cscott! Could you please read and sign https://participate.whatwg.org/agreement?

@cscott
Copy link
Author

cscott commented Aug 9, 2018

Done!

@annevk annevk mentioned this pull request Aug 10, 2018
Closed
@David263

This comment has been minimized.

Sign in to view
@David263 David263 mentioned this pull request Jan 14, 2019
Closed
@annevk annevk added the do not merge yet Pull request must not be merged per rationale in comment label Dec 6, 2019
Base automatically changed from master to main January 15, 2021 07:32
annevk added a commit that referenced this pull request Jan 26, 2021
@annevk
Use a single exception for name validation (follow-up)
9b26855 
Once you have thrown for all QName cases, you can no longer throw for Name cases. Tested as part of #423.

Also cleanup createElementNS() domintro.

Fixes #671 and closes #675.
@annevk annevk mentioned this pull request Jan 26, 2021
Merged
@annevk annevk closed this in #945 Jan 27, 2021
annevk added a commit that referenced this pull request Jan 27, 2021
@annevk
Use a single exception for name validation (follow-up)
c80cbf5 
Once you have thrown for all QName cases, you can no longer throw for Name cases. Tested as part of #423.

Also cleanup createElementNS()'s domintro.

Fixes #671 and closes #675.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@annevk annevk annevk approved these changes

Assignees
No one assigned
Labels
do not merge yet Pull request must not be merged per rationale in comment
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

createElementNS() QName/Name confusion
3 participants
@cscott @annevk @David263