Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use a single exception for name validation (follow-up) #945

Merged
merged 3 commits into from
Jan 27, 2021
Merged

Use a single exception for name validation (follow-up) #945

merged 3 commits into from
Jan 27, 2021

Conversation

annevk
Copy link
Member

@annevk annevk commented Jan 26, 2021 •
edited by pr-preview bot
Loading

Once you have thrown for all QName cases, you can no longer throw for Name cases. Tested as part of #423.

Also cleanup createElementNS() domintro.

Fixes #671 and closes #675.

💥 Error: 500 Internal Server Error 💥

PR Preview failed to build. (Last tried on Jan 27, 2021, 5:19 PM UTC).

More

PR Preview relies on a number of web services to run. There seems to be an issue with the following one:

🚨 CSS Spec Preprocessor - CSS Spec Preprocessor is the web service used to build Bikeshed specs.

🔗 Related URL

<!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML 2.0//EN">
<html><head>
<title>500 Internal Server Error</title>
</head><body>
<h1>Internal Server Error</h1>
<p>The server encountered an internal error or
misconfiguration and was unable to complete
your request.</p>
<p>Please contact the server administrator at 
 [no address given] to inform them of the time this error occurred,
 and the actions you performed just before this error.</p>
<p>More information about this error may be available
in the server error log.</p>
<hr>
<address>Apache/2.4.10 (Debian) Server at api.csswg.org Port 443</address>
</body></html>

If you don't have enough information above to solve the error by yourself (or to understand to which web service the error is related to, if any), please file an issue.

@annevk
Use a single exception for name validation (follow-up)
9b26855 
Once you have thrown for all QName cases, you can no longer throw for Name cases. Tested as part of #423.

Also cleanup createElementNS() domintro.

Fixes #671 and closes #675.
@annevk annevk requested a review from domenic January 26, 2021 16:23
This was referenced Jan 26, 2021
Closed
Closed
@annevk annevk merged commit c80cbf5 into main Jan 27, 2021
@annevk annevk deleted the annevk/name-validation branch January 27, 2021 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@domenic domenic domenic approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

createElementNS() QName/Name confusion
2 participants
@annevk @domenic