-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove HTMLAreaElement.hreflang and .type #232
Comments
I tend to think we should either keep them on both, or obsolete them on |
If you mean merely moving them to the obsolete section, then that sounds fine to me, but trying to remove things already shipping on HTMLAnchorElement doesn't seem worthwhile. |
I'd be interested to know if the |
My understanding is that these don't do anything on |
I see that |
Technically user agents were supposed to create all kinds of cool UI around these attributes, but they didn't. So I would say that the content attributes should also move. However, |
Right, for the |
Yeah, so my tentative proposal would be that we obsolete |
Do you think we should make them obsolete but conforming, or non-conforming? |
I'm not sure. They are useless since there's no support. But we might not want to annoy folks that have added them anyway with validator messages. |
I see 14,347 instances of 1,161 instances of I don't think we should obsolete these, that seems like wasting authors' time, similarly to obsoleting |
It's very low cost, by why must we have the IDL attributes just because we can't emit validator warnings? |
@zcorpan what is wrong with obsolete but conforming? They don't anything useful after all. |
Things in the spec are obsolete but conforming because we want the validator to issue warning (but not error). I don't think that is good here. Saying that it is obsolete but conforming but validators shouldn't whine about it, either, seems confusing. How do you explain The IDL attributes should be there for consistency; I consider it a bugfix from HTML4. |
Maybe we should drop |
Does the spec always have IDL attributes corresponding to valid content attributes? I guess since we removed the microdata API that's no longer strictly true, right? Are there other cases? |
ARIA and |
Also We could remove the not-implemented IDL attributes from the spec but still leave the attributes as conforming, saying that this is a historical quirk and you have to use |
I still think we should also dissuade folks from the notion that they might be useful. Obsolete, but conforming seems fine. The validator can simply opt not to show a warning for them since they're harmless. |
Given that these are currently interoperably non-implemented, I don't think going through a period of many years where some browsers have the reflected IDL attributes and others don't would be worthwhile. A "all conforming content attributes should be reflected" design rule doesn't seem important enough to me, at least. I think the "obsolete but conforming" category seems fine, so that we continue to say "all conforming content attributes should be reflected". |
I'm OK with removing the IDL attribute since there's precedent. But there are a lot of attributes that don't do anything useful according to user agents, but are useful hooks for scripts, styles, or other parts of the ecosystem. (E.g. microdata, cite attribute, datetime attribute, ...) I don't see any reason to mark this as obsolete. |
The content attributes are left as conforming, the IDL attributes are removed simply because they are not implemented, and implementing them would not be particularly worthwhile, while temporarily decreasing interoperability until all browsers have implemented them. Fixes #232
OK, I've submitted a pull request that merely removes the IDL attributes. Does there need to be an explanation of why the IDL attributes are missing? Note that the spec still says "The |
The content attributes are left as conforming, the IDL attributes are removed simply because they are not implemented, and implementing them would not be particularly worthwhile, while temporarily decreasing interoperability until all browsers have implemented them. Fixes #232
The content attributes are left as conforming, the IDL attributes are removed simply because they are not implemented, and implementing them would not be particularly worthwhile, while temporarily decreasing interoperability until all browsers have implemented them. Fixes #232
@domenic I guess I did not articulate things carefully enough. The precedent for missing IDL attributes all were carefully considered. None of them were omitted due to not being implemented (in fact, Chrome at some point supported What we have now does not make sense and has created a logical inconsistency. |
OK, so the outrage of making these non-conforming would probably be very small. @annevk, does that sounds OK, or do you have some other preference? |
It still seems weird to have our hyperlink elements diverged again, but it seems somewhat better than the new status quo. |
I basically think that all options are better than having implementations diverge by fiddling with attributes that don't actually do anything at all. Proposal:
This would put Objections? |
No objections from me. All sounds reasonable |
Not quite; I see 2,565 I think I would prefer to make |
You don't think consistency between |
I think it is, but that is not the only consideration, and I think it is less important than making people spend time thinking about what they should do about their |
My suggestion was "Make |
Currently things are obsolete but conforming because we want validators to give a warning (but not an error). I want no message for |
OK, I just didn't read past the heading of "Obsolete but conforming features", the first paragraph says "Features listed in this section will trigger warnings in conformance checkers." I guess we don't have a category of things that are useless and harmless. Unless we introduce such a category, we have to chose between two different forms of inconsistency:
I'm really fine either way, or perhaps there are other options. If anyone feels strongly, please make a very concrete suggestion :) |
Yes. I'm also fine with either of those. @annevk you didn't like the current spec text, are you OK with the other option? |
I'm happier with the second option. To have |
I don't mind warnings for things where it is useful to make people think about changing their markup, e.g. change |
|
For the record here (I know this issue is resolved now), in implementing warnings in the Nu HTML Checker, I take statements about warnings in the spec to be somewhat advisory (I think we currently implement most of the ones it defines, though not all), so there is room for a gray area here with regard to whether or not to emit warnings for particular cases. And incidentally as I’ve noted in other places, we also emit some warnings that are not necessarily directly associated with any specific requirements in the spec. So the warning-level messages from the checker are already somewhat discretionary in practice, and we can avoid emitting warnings for particular obsolete-but-conforming cases if the prevailing agreement is that’s what we should be doing. |
@sideshowbarker, does that mean that you would support making |
Yes, if that's what you and @zcorpan and @annevk and @domenic think would be the best way to deal with it.
Yes, some wording refinement like that would be appropriate, I think. |
I'm a bit confused about what the goal of that section would be if not to trigger warnings in validators. Is it to avoid having people who write tutorials include the feature? Something else? |
The point would be to hide useless features from view, much like the things in https://html.spec.whatwg.org/#Document-partial |
I see that the issue is closed and hreflang has fortunately not been removed from the link element. So just for the record: It is not useless! While browser may not make use of these attributes, Google and possibly other search engines "use the rel='alternate' hreflang='x' attributes to serve the correct language or regional URL in search results". |
Yeah, I don't think it has been suggested to obsolete it for |
Part of whatwg#232.
Part of whatwg#232.
Part of whatwg#232. This also fixes an issue where the Docker build would always used the cached Docker container for Wattsi, so updating $WATTSI_LATEST would cause any further Docker builds to warn that Wattsi was out of date. Now it uses the one based on the $WATTSI_LATEST variable.
Closes whatwg#232.
There's a review to add
HTMLAreaElement.hreflang
in Blink:https://codereview.chromium.org/1381913002/
However, it doesn't look like the hreflang attribute is actually used internally, and no other engine exposes the
HTMLAreaElement.hreflang
attribute, whileHTMLAnchorElement.hreflang
appears to be universally supported.The situation is the same with
HTMLAreaElement.type
.The text was updated successfully, but these errors were encountered: