Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the HTMLAreaElement.hreflang and type IDL attributes #236

Merged
merged 1 commit into from
Oct 7, 2015

Conversation

foolip
Copy link
Member

@foolip foolip commented Oct 7, 2015

The content attributes are left as conforming, the IDL attributes are
removed simply because they are not implemented, and implementing them
would not be particularly worthwhile, while temporarily decreasing
interoperability until all browsers have implemented them.

Fixes #232

@zcorpan
Copy link
Member

zcorpan commented Oct 7, 2015

Can you add a note that they are intentionally missing?

The content attributes are left as conforming, the IDL attributes are
removed simply because they are not implemented, and implementing them
would not be particularly worthwhile, while temporarily decreasing
interoperability until all browsers have implemented them.

Fixes #232
@foolip
Copy link
Member Author

foolip commented Oct 7, 2015

I've added "hreflang and type are not reflected" as a comment in the IDL block. You might want to generated the output to see if you like how it looks, I doubt there are any other cases where a content attribute is linked to from within an IDL block.

@zcorpan
Copy link
Member

zcorpan commented Oct 7, 2015

Use span instead of code if you want the same style as other links in IDL blocks.

@foolip
Copy link
Member Author

foolip commented Oct 7, 2015

Thanks, that look better, PTAL.

@zcorpan zcorpan merged commit 790479a into master Oct 7, 2015
@zcorpan zcorpan deleted the hreflang-type branch October 7, 2015 13:45
zcorpan pushed a commit to web-platform-tests/wpt that referenced this pull request Sep 14, 2016
Drop area.hreflang / area.type from HTML reflection test given that those attributes
are obsolete and no longer part of the HTML specification.

See whatwg/html#236
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants