-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove "compatibility caseless" matching #1941
Conversation
This fixes #1666. As discussed there, browsers are not interoperable about what type of Unicode case-insensitivity they implement here, with WebKit even using case-sensitive matching for the radio button case (but not for the image map case). Data from Blink's use counters reveals however that the Unicode case-insensitivity is never triggered, and even ASCII case-insensitivity is triggered extraordinarily rarely. Additionally, the semantics of these attributes is more like an identifier than anything else, and so case-insensitive comparison never really made sense in the first place (it was only done for legacy Internet Explorer compatibility). As such, we move to converge on case-sensitive matching in all cases.
This follows the spec change proposed at whatwg/html#1941.
This follows the spec change proposed at whatwg/html#1941.
Tests at web-platform-tests/wpt#4044 for radio button groups. I can't figure out how to test image maps. It might be possible with something really complicated (synethetic click events at some section of the page that is covered by an image map??) but given that there are no such existing tests for me to model on, I'm going to ask that we skip requiring tests for that. |
This follows the spec change proposed at whatwg/html#1941.
I don't think you can test it without some kind of framework that can actually send UI events. However, you could create a manual test for it which would be nice for implementers and reviewers. Really happy we can remove this wart by the way. |
You can use |
Thanks for the tip. Tests updated. Anyone approve the PR itself? |
Oops, this PR LGTM. |
This follows the spec change proposed at whatwg/html#1941.
|
The testcase didn't match to the current specification. See whatwg/html#1941
This fixes #1666. As discussed there, browsers are not interoperable
about what type of Unicode case-insensitivity they implement here, with
WebKit even using case-sensitive matching for the radio button case (but
not for the image map case). Data from Blink's use counters reveals
however that the Unicode case-insensitivity is never triggered, and even
ASCII case-insensitivity is triggered extraordinarily rarely.
Additionally, the semantics of these attributes is more like an
identifier than anything else, and so case-insensitive comparison never
really made sense in the first place (it was only done for legacy
Internet Explorer compatibility). As such, we move to converge on
case-sensitive matching in all cases.
Tests incoming, will file browser bugs after merge.