-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add HTML AAM considerations to PR template and enable for HTML #76
Conversation
What about other horizontal concerns, e.g. security, privacy, sustainability, and the like? Why would separate PRs be created for a11y/i18n? Shouldn't these types of issues be addressed in PR being created with the template? I might prefer to just see the
Or am I not understanding? (PS> Consider adding i18n-tracker label to this PR so that it's tracked in our repo) |
Hmm yeah. Maybe I should restrict this to accessibility and in particular HTML AAM which "frequently" ends up needing changes due to changes in HTML semantics. Most other horizontal concerns don't really have that kind of integration. |
thanks for this @annevk i think this would be a good add. arguably a second check for aria in html issue/pr might be helpful? but, maybe just html aam is enough since that'll get it on the ARIA wg's radar and then we can determine if an aria in html issue/pr would be necessary or not. |
See whatwg/spec-factory#76 for context.
See whatwg/spec-factory#76 for context.
elif variable == "a11y-check": | ||
output = "" | ||
if data: | ||
output = "\n- [ ] Corresponding [HTML AAM](https://w3c.github.io/html-aam/) & [WAI-ARIA](https://w3c.github.io/aria/) issues & PRs:" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@scottaohara asked to add "ARIA in HTML" which is https://w3c.github.io/html-aria/ . I think ARIA usually don't need changes for changes in HTML.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sigh. Okay. Will create some more PRs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And thanks for catching!
@domenic @scottaohara let me know if you have any thoughts. The main thing this adds to the PR template for HTML will look like this:
and I would expect it to be completed like this:
or:
(This has been edited to instead feature the latest suggestion.)