Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HTML AAM considerations to PR template and enable for HTML #76

Merged
merged 4 commits into from
Dec 6, 2024
Merged

Add HTML AAM considerations to PR template and enable for HTML #76

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
462f719
Add optional a11y/i18n considerations to PR template and enable for HTML
annevk Dec 4, 2024
b271367
reduce scope
annevk Dec 5, 2024
0524c5b
increase scope slightly again
annevk Dec 6, 2024
8586b5e
rename variable
annevk Dec 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion PULL_REQUEST_TEMPLATE.md.template
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ If you think your PR is ready to land, please double-check that the build is pas
- [ ] [Implementation bugs](https://github.com/whatwg/meta/blob/main/MAINTAINERS.md#handling-pull-requests) are filed:
* Chromium: …
* Gecko: …
* WebKit: …@@extra_implementers@@
* WebKit: …@@extra_implementers@@@@a11y-check@@
- [ ] [MDN issue](https://github.com/whatwg/meta/blob/main/MAINTAINERS.md#handling-pull-requests) is filed: …
- [ ] The top of this comment includes a [clear commit message](https://github.com/whatwg/meta/blob/main/COMMITTING.md) to use. <!-- If you created this PR from a single commit, Github copied its message. Otherwise, you need to add a commit message yourself. -->

Expand Down
3 changes: 2 additions & 1 deletion factory.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,8 @@
"extra_implementers": [
"Deno (only for timers, structured clone, base64 utils, channel messaging, module resolution, web workers, and web storage)",
"Node.js (only for timers, structured clone, base64 utils, channel messaging, and module resolution)"
]
],
"a11y-check": true
},
"infra": {
"not_these_templates": ["PULL_REQUEST_TEMPLATE.md"],
Expand Down
6 changes: 6 additions & 0 deletions factory.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,11 @@ def fill_template(contents, variables):
for entry in data:
output += "\n * {}: …".format(entry)
data = output
elif variable == "a11y-check":
output = ""
if data:
output = "\n- [ ] Corresponding [HTML AAM](https://w3c.github.io/html-aam/) & [WAI-ARIA](https://w3c.github.io/aria/) issues & PRs:"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@scottaohara asked to add "ARIA in HTML" which is https://w3c.github.io/html-aria/ . I think ARIA usually don't need changes for changes in HTML.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sigh. Okay. Will create some more PRs.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#77
whatwg/html#10830

And thanks for catching!

data = output
contents = contents.replace("@@{}@@".format(variable), data)
return contents

Expand All @@ -99,6 +104,7 @@ def update_files(shortname, name, in_main=False):
".gitignore": [],
"not_these_templates": None,
"extra_implementers": [],
"a11y-check": False,
"readme": None
}
if shortname in FACTORY_DB:
Expand Down