Update Parnassus names #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nvkelso
reviewed
Sep 14, 2021
data/858/659/57/85865957.geojson
Outdated
| "Panassus Ashbury Heights" | ||
| ], | ||
| "name:und_x_variant":[ | ||
| "Parnassus Ashbury Heights", | ||
| "Parnassus Heights" |
There was a problem hiding this comment.
Do we need to add the misspelling to the variants list to comply with our lifecycle guidelines and not churn the ID?
There was a problem hiding this comment.
Added the "Panassus" name back in.. we've been lenient when it comes to editing misspellings in place, but I think it's fine to add the variant in this case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes whosonfirst-data/whosonfirst-data#1962.
This PR removes a bogus variant name in the Tenderloin neighbourhood, and corrects the name and
wof:nameproperties in the Parnassus neighbourhood. The misspelled names were not stored as variants; I've just edited in place and swappedundnames toeng.No PIP work, can merge when approved.