[EJBCLIENT-193] Implement affinity substitution #200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in order to allow the ProtocolV3ObjectResolver to get invoked when unmarshalling an Affinity.LOCAL instance
dmlloyd
reviewed
Feb 7, 2017
| final class ProtocolV3ObjectResolver implements ObjectResolver { | ||
| private final Affinity peerURIAffinity; | ||
|
|
||
| ProtocolV3ObjectResolver(final URI peerURI) { |
There was a problem hiding this comment.
I think this is the local URI not the peer's URI, right? Or am I reading this backwards?
There was a problem hiding this comment.
Ah I see, we swap on the opposite end for V3 than we do in V1, just like we discussed. Never mind!
dmlloyd
reviewed
Feb 7, 2017
| @@ -100,7 +100,6 @@ | |||
| final Object[] simpleObjects = { | |||
| TransactionID.PRIVATE_DATA_KEY, | |||
| Affinity.NONE, | |||
| Affinity.LOCAL, | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.jboss.org/browse/EJBCLIENT-193