-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EJBCLIENT-193] Implement affinity substitution #200
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -21,28 +21,36 @@ | |
import org.jboss.ejb.client.AbstractEJBMetaData; | ||
import org.jboss.ejb.client.Affinity; | ||
import org.jboss.ejb.client.EJBMetaDataImpl; | ||
import org.jboss.ejb.client.NodeAffinity; | ||
import org.jboss.ejb.client.URIAffinity; | ||
import org.jboss.marshalling.ObjectResolver; | ||
|
||
/** | ||
* @author <a href="mailto:[email protected]">David M. Lloyd</a> | ||
*/ | ||
final class ProtocolV1ObjectResolver implements ObjectResolver { | ||
static final ProtocolV1ObjectResolver INSTANCE = new ProtocolV1ObjectResolver(); | ||
private final NodeAffinity nodeAffinity; | ||
|
||
private ProtocolV1ObjectResolver() { | ||
ProtocolV1ObjectResolver(final String nodeName) { | ||
nodeAffinity = new NodeAffinity(nodeName); | ||
} | ||
|
||
public Object readResolve(final Object replacement) { | ||
if (replacement instanceof EJBMetaDataImpl) { | ||
return ((EJBMetaDataImpl) replacement).toAbstractEJBMetaData(); | ||
} else if ((replacement instanceof NodeAffinity) && replacement.equals(nodeAffinity)) { | ||
// Swap a node affinity with the name of this node with a local affinity | ||
return Affinity.LOCAL; | ||
} | ||
return replacement; | ||
} | ||
|
||
public Object writeReplace(final Object original) { | ||
if (original instanceof URIAffinity || original == Affinity.LOCAL) { | ||
if (original instanceof URIAffinity) { | ||
return Affinity.NONE; | ||
} else if (original == Affinity.LOCAL) { | ||
// Swap a local affinity with a node affinity with the name of this node | ||
return nodeAffinity; | ||
} else if (original instanceof AbstractEJBMetaData) { | ||
return new EJBMetaDataImpl((AbstractEJBMetaData<?, ?>) original); | ||
} | ||
|
52 changes: 52 additions & 0 deletions
52
src/main/java/org/jboss/ejb/protocol/remote/ProtocolV3ObjectResolver.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,52 @@ | ||
/* | ||
* JBoss, Home of Professional Open Source. | ||
* Copyright 2017 Red Hat, Inc., and individual contributors | ||
* as indicated by the @author tags. | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
|
||
package org.jboss.ejb.protocol.remote; | ||
|
||
import java.net.URI; | ||
|
||
import org.jboss.ejb.client.Affinity; | ||
import org.jboss.ejb.client.URIAffinity; | ||
import org.jboss.marshalling.ObjectResolver; | ||
|
||
/** | ||
* @author <a href="mailto:[email protected]">Farah Juma</a> | ||
*/ | ||
final class ProtocolV3ObjectResolver implements ObjectResolver { | ||
private final Affinity peerURIAffinity; | ||
|
||
ProtocolV3ObjectResolver(final URI peerURI) { | ||
peerURIAffinity = Affinity.forUri(peerURI); | ||
} | ||
|
||
public Object readResolve(final Object replacement) { | ||
// Swap a local affinity with a URI affinity with the peer's URI | ||
if (replacement == Affinity.LOCAL) { | ||
return peerURIAffinity; | ||
} | ||
return replacement; | ||
} | ||
|
||
public Object writeReplace(final Object original) { | ||
// Swap a URI affinity with the peer's URI with a local affinity | ||
if ((original instanceof URIAffinity) && original.equals(peerURIAffinity)) { | ||
return Affinity.LOCAL; | ||
} | ||
return original; | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -100,7 +100,6 @@ final class ProtocolV3ObjectTable implements ObjectTable { | |
final Object[] simpleObjects = { | ||
TransactionID.PRIVATE_DATA_KEY, | ||
Affinity.NONE, | ||
Affinity.LOCAL, | ||
Affinity.WEAK_AFFINITY_CONTEXT_KEY, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Ah, forgot about that... |
||
EJBClientInvocationContext.PRIVATE_ATTACHMENTS_KEY, | ||
AttachmentKeys.TRANSACTION_ID_KEY, | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is the local URI not the peer's URI, right? Or am I reading this backwards?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah I see, we swap on the opposite end for V3 than we do in V1, just like we discussed. Never mind!