Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EJBCLIENT-193] Implement affinity substitution #200

Merged
merged 2 commits into from
Feb 7, 2017
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -144,10 +144,11 @@ class EJBClientChannel {
if (version < 3) {
configuration.setClassTable(ProtocolV1ClassTable.INSTANCE);
configuration.setObjectTable(ProtocolV1ObjectTable.INSTANCE);
configuration.setObjectResolver(ProtocolV1ObjectResolver.INSTANCE);
configuration.setObjectResolver(new ProtocolV1ObjectResolver(channel.getConnection().getEndpoint().getName()));
configuration.setVersion(2);
} else {
configuration.setObjectTable(ProtocolV3ObjectTable.INSTANCE);
configuration.setObjectResolver(new ProtocolV3ObjectResolver(channel.getConnection().getPeerURI()));
configuration.setVersion(4);
// server does not present v3 unless the transaction service is also present
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -118,10 +118,11 @@ final class EJBServerChannel {
if (version < 3) {
configuration.setClassTable(ProtocolV1ClassTable.INSTANCE);
configuration.setObjectTable(ProtocolV1ObjectTable.INSTANCE);
configuration.setObjectResolver(ProtocolV1ObjectResolver.INSTANCE);
configuration.setObjectResolver(new ProtocolV1ObjectResolver(channel.getConnection().getEndpoint().getName()));
configuration.setVersion(2);
} else {
configuration.setObjectTable(ProtocolV3ObjectTable.INSTANCE);
configuration.setObjectResolver(new ProtocolV3ObjectResolver(channel.getConnection().getPeerURI()));
configuration.setVersion(4);
}
marshallerFactory = new RiverMarshallerFactory();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,28 +21,36 @@
import org.jboss.ejb.client.AbstractEJBMetaData;
import org.jboss.ejb.client.Affinity;
import org.jboss.ejb.client.EJBMetaDataImpl;
import org.jboss.ejb.client.NodeAffinity;
import org.jboss.ejb.client.URIAffinity;
import org.jboss.marshalling.ObjectResolver;

/**
* @author <a href="mailto:[email protected]">David M. Lloyd</a>
*/
final class ProtocolV1ObjectResolver implements ObjectResolver {
static final ProtocolV1ObjectResolver INSTANCE = new ProtocolV1ObjectResolver();
private final NodeAffinity nodeAffinity;

private ProtocolV1ObjectResolver() {
ProtocolV1ObjectResolver(final String nodeName) {
nodeAffinity = new NodeAffinity(nodeName);
}

public Object readResolve(final Object replacement) {
if (replacement instanceof EJBMetaDataImpl) {
return ((EJBMetaDataImpl) replacement).toAbstractEJBMetaData();
} else if ((replacement instanceof NodeAffinity) && replacement.equals(nodeAffinity)) {
// Swap a node affinity with the name of this node with a local affinity
return Affinity.LOCAL;
}
return replacement;
}

public Object writeReplace(final Object original) {
if (original instanceof URIAffinity || original == Affinity.LOCAL) {
if (original instanceof URIAffinity) {
return Affinity.NONE;
} else if (original == Affinity.LOCAL) {
// Swap a local affinity with a node affinity with the name of this node
return nodeAffinity;
} else if (original instanceof AbstractEJBMetaData) {
return new EJBMetaDataImpl((AbstractEJBMetaData<?, ?>) original);
}
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,52 @@
/*
* JBoss, Home of Professional Open Source.
* Copyright 2017 Red Hat, Inc., and individual contributors
* as indicated by the @author tags.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/

package org.jboss.ejb.protocol.remote;

import java.net.URI;

import org.jboss.ejb.client.Affinity;
import org.jboss.ejb.client.URIAffinity;
import org.jboss.marshalling.ObjectResolver;

/**
* @author <a href="mailto:[email protected]">Farah Juma</a>
*/
final class ProtocolV3ObjectResolver implements ObjectResolver {
private final Affinity peerURIAffinity;

ProtocolV3ObjectResolver(final URI peerURI) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is the local URI not the peer's URI, right? Or am I reading this backwards?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah I see, we swap on the opposite end for V3 than we do in V1, just like we discussed. Never mind!

peerURIAffinity = Affinity.forUri(peerURI);
}

public Object readResolve(final Object replacement) {
// Swap a local affinity with a URI affinity with the peer's URI
if (replacement == Affinity.LOCAL) {
return peerURIAffinity;
}
return replacement;
}

public Object writeReplace(final Object original) {
// Swap a URI affinity with the peer's URI with a local affinity
if ((original instanceof URIAffinity) && original.equals(peerURIAffinity)) {
return Affinity.LOCAL;
}
return original;
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,6 @@ final class ProtocolV3ObjectTable implements ObjectTable {
final Object[] simpleObjects = {
TransactionID.PRIVATE_DATA_KEY,
Affinity.NONE,
Affinity.LOCAL,
Affinity.WEAK_AFFINITY_CONTEXT_KEY,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, forgot about that...

EJBClientInvocationContext.PRIVATE_ATTACHMENTS_KEY,
AttachmentKeys.TRANSACTION_ID_KEY,
Expand Down