Restore File::unique() helper

[damsfx]

Restore :

• 68bb7ac (partially)
• 76a4302

[mjauvin]

@damsfx you also need to add the method signature to the File facade (winter/storm/src/Support/Facades/File.php)

[damsfx]

@damsfx you also need to add the method signature to the File facade (winter/storm/src/Support/Facades/File.php)

@mjauvin Just done it!
However, having done this on the develop branch was an error ... I'm always afraid in this case of not being in line with the winter repo.

[github-actions]

This pull request will be closed and archived in 3 days, as there has been no activity in the last 60 days.
If this is still being worked on, please respond and we will re-open this pull request.
If this pull request is critical to your business, consider joining the Premium Support Program where a Service Level Agreement is offered.

[LukeTowers]

Suggested change

	* winter.txt, [winter_1.txt, winter_2.txt] -> winter_3.txt
	* winter.txt, [winter_1.txt, winter_3.txt] -> winter_4.txt
	* winter.txt, [winter.txt] -> winter_1.txt
	* winter.txt, [winter.txt, winter_1.txt, winter_2.txt] -> winter_3.txt
	* winter.txt, [winter.txt, winter_1.txt, winter_3.txt] -> winter_4.txt
	* winter.txt, [winter_1.txt, winter_3.txt] -> winter.txt

@damsfx it should probably allow the input to be returned unmodified if it doesn't exist within the array.

[damsfx]

@LukeTowers If the entry doesn't exist in the array, it must be returned with another index anyway, right?

[LukeTowers]

@damsfx I'm making the suggestion that if it doesn't exist in the array it should be returned unmodified. The method is intended to give you a unique filename provided the input of a desired filename and a list of already existing options. If the filename provided is already unique, then there's no need to modify it.

[damsfx]

@LukeTowers So in a such case, the same filename is needed in the array of references to get the next incremented name.

[LukeTowers]

The suggested change above should list all the cases that I think the method should need to handle, I've already updated the tests so it should just require a minor change in the method itself.

[damsfx]

@LukeTowers Your modifications in tests goes to a failure for me.

// File already unique, return original
'winter.cms' => ['winter.cms', ['winter_1.cms']],

FAILED !
The function return wintert_2.cms in that case.

What I don't understand is why you want to return the unmodified value if it's unique.
In any case, we should return the incremented value! 🤯

(new Filesystem())->unique('winter.cms', ['test.cms']);   // winter_1.cms
(new Filesystem())->unique('winter.cms', []);             // winter_1.cms

[LukeTowers]

@damsfx The tests are failing because the method doesn't currently have the logic to allow the name to be returned unmodified. The method claims to return a unique filename given the input of a desired filename and a list of existing filenames; why does it have to always return an incremented value if the desired filename isn't present?