-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: feature federation msg failed to send handling (AR-3015) #1547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yamilmedina
changed the title
feat: revert - feature federation msg failed to send handling
feat: feature federation msg failed to send handling (AR-3015)
Mar 1, 2023
ohassine
approved these changes
Mar 1, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔙 ✅
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Mar 1, 2023
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jun 23, 2023
* Revert "feat: feature federation msg failed to send handling (AR-3015) (#1547)" This reverts commit 6011673. * chore(migration): out of conflict * chore: more code documentation * chore: recover small improv for uneeded call * chore: detekt * fix: sq migration updated after a really long time =/ * feat: offline backends - handling list-prekeys failed to list (AR-3171) (#1662) * feat: remove unused code, add mapping of proto contentc * feat: expand message target to include users to ignore * feat: resetting intentions on message targets * feat: resetting intentions on message targets * feat: test adjustment for target change * feat: adjusting signatures and simplify message sender mapping * feat: adjusting signatures and simplify message sender mapping * feat: adjusting signatures and simplify message sender mapping * feat: adjusting signatures and simplify message sender mapping * feat: clean code, and fallback for clients targets * feat: ignoring failed recipients mapping for non regular messages * feat: ignoring failed recipients mapping for non regular messages * feat: ignoring failed recipients mapping for non regular messages * feat: adding test coverage * feat: adding test coverage * feat: adding test coverage * chore: tmp for merge * feat: wip, merge sqw * feat: offline backends - users metadata (AR-3124) (#1698) * feat: adjust query to hide 1:1 convos without metadata * feat: adjustment query to consider deleted users logic as it is now * feat: tests for query conversations details * feat: pr comments single quotes * feat(offline-backends): users and conversations without metadata refetch pt1. (AR-3123) (#1736) * feat: adjust query to hide 1:1 convos without metadata * feat: adjustment query to consider deleted users logic as it is now * feat: tests for query conversations details * feat: persistence for getting users out of sync * feat: persistence for getting users out of sync * feat: pr comments single quotes * feat: invok operator * feat: persist failed convos * feat: cleanup * feat: tests cov * feat: tests cov * feat: tests cov * feat: tests cov * feat: refactor, persist users withoutmetadata with dedicated field * feat: refactor, relay on missing metadata field for refetch usres * feat: refactor, relay on missing metadata field for refetch conversations * feat: refactor, relay on missing metadata field for refetch conversations * feat: refactor, relay on missing metadata field for refetch conversations * feat: refactor, fixing tests * chore: add migration tests * feat(offline-backends): users and conversations without metadata refetch pt2. (AR-3123) (#1740) * feat: adjust query to hide 1:1 convos without metadata * feat: adjustment query to consider deleted users logic as it is now * feat: tests for query conversations details * feat: persistence for getting users out of sync * feat: persistence for getting users out of sync * feat: pr comments single quotes * feat: invok operator * feat: persist failed convos * feat: skeleton classes to build upon * feat: skeleton classes to build upon * feat: skeleton classes to build upon * feat: queries and metadata for syncing metadata * feat: provider di * feat: cleanup * feat: cleanup, clock instant * feat: tests cov * feat: tests cov * feat: tests cov * feat: tests cov * feat: refactor, persist users withoutmetadata with dedicated field * feat: refactor, relay on missing metadata field for refetch usres * feat: refactor, relay on missing metadata field for refetch conversations * feat: refactor, relay on missing metadata field for refetch conversations * feat: refactor, relay on missing metadata field for refetch conversations * feat: refactor, fixing tests * chore: add migration tests * chore: ddetekt * chore: new query * chore: test for use case * chore: test cov * chore: test cov * chore: change strategy to run sync after inc * chore: logging * chore: logging * chore: logging ref * fix: db ops * fix: db ops, user persistence fixed * chore: test cov * feat: test coverage * chore: wip for merge * fix: handle edge case error when no sessions * fix: tests * feat: wip merge * feat: wip merge * feat: conversation creation with offline backends (WPB-364) (#1774) * feat: add new response handling create convo v4 * feat: add new response handling create convo v4 test * feat: add new response handling create convo v4 test * feat: add tests cases and persitence of msg for failed to add * feat: add tests cases and persitence of msg for failed to add --------- Co-authored-by: Mohamad Jaara <[email protected]> * chore: preparing for rebase * chore: preparing merge * chore: preparing merge, better naming for func * chore: preparing merge, coverage * chore: preparing merge, coverage --------- Co-authored-by: Mohamad Jaara <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit c8170cf.
persistence and failed to send case (AR-3015) ( (#1531)