feat(offline-backends): users and conversations without metadata refetch pt1. (AR-3123) #1736

yamilmedina · 2023-05-15T10:16:39Z

PR Submission Checklist for internal contributors

The PR Title
- conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
- contains a reference JIRA issue number like SQPIT-764
- answers the question: If merged, this PR will: ... ³
The PR Description
- is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

We need to refetch users and conversations without metadata.

Causes (Optional)

In case we don't have data due to a remote backend being offline, the clients will be able to refetch this data on demand.

Solutions

This PR adds:

Persist of failed conversations with defailt values, so we can refetch them later
Logic and use case to refetch users without metadata on demand.

Testing

Test Coverage (Optional)

I have added automated test to this contribution

Notes (Optional)

Will raise a new PR to add a new mechanism for refetch every 3 hours if the app comes to foreground.

PR Post Submission Checklist for internal contributors (Optional)

Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References

https://sparkbox.com/foundry/semantic_commit_messages
https://github.com/wireapp/.github#usage
E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

…ederation-usersmetadata

…n-usersmetadata-refetch

…tion-usersmetadata-refetch

github-actions · 2023-05-15T10:34:57Z

Unit Test Results

  358 files ±0   358 suites ±0 1m 10s ⏱️ -31s
1 892 tests +2 1 810 ✔️ +2 82 💤 ±0 0 ❌ ±0

Results for commit cc2e829. ± Comparison against base commit 2c3998d.

♻️ This comment has been updated with latest results.

codecov-commenter · 2023-05-15T10:46:38Z

Codecov Report

Merging #1736 (cc2e829) into feat/epic-federation-offline-messages (2c3998d) will increase coverage by 0.23%.
The diff coverage is 68.57%.

@@                             Coverage Diff                             @@
##             feat/epic-federation-offline-messages    #1736      +/-   ##
===========================================================================
+ Coverage                                    53.44%   53.68%   +0.23%     
+ Complexity                                    1494     1492       -2     
===========================================================================
  Files                                          931      924       -7     
  Lines                                        34501    34509       +8     
  Branches                                      3039     3032       -7     
===========================================================================
+ Hits                                         18439    18526      +87     
+ Misses                                       14840    14759      -81     
- Partials                                      1222     1224       +2

alexandreferris

Great work! I just have one tiny comment about function naming :)

alexandreferris · 2023-05-16T15:35:25Z

logic/src/commonMain/kotlin/com/wire/kalium/logic/data/conversation/ConversationMapper.kt

@@ -347,6 +349,24 @@ internal class ConversationMapperImpl(
        )
    }

+    override fun fromFailedConversationToEntity(conversationId: NetworkQualifiedId): ConversationEntity = ConversationEntity(


as we are hardcoding the conversation type to group maybe we can rename the function name to fromFailedGroupConversationToEntity just so its a bit more clear whats the goal?

Sorry, missed this PR and only commented on part 2.

I think we should consider adding field like hasIncompleteMetadata = true in this case. This way we don't need to rely on a heuristic like name being null to figure out that conversation needs to be re-fetched.

Thanks for the suggestions, done !

typfel · 2023-05-16T15:45:41Z

logic/src/commonMain/kotlin/com/wire/kalium/logic/data/conversation/ConversationMapper.kt

@@ -347,6 +349,24 @@ internal class ConversationMapperImpl(
        )
    }

+    override fun fromFailedConversationToEntity(conversationId: NetworkQualifiedId): ConversationEntity = ConversationEntity(


Sorry, missed this PR and only commented on part 2.

I think we should consider adding field like hasIncompleteMetadata = true in this case. This way we don't need to rely on a heuristic like name being null to figure out that conversation needs to be re-fetched.

…ions

typfel

👍

* Revert "feat: feature federation msg failed to send handling (AR-3015) (#1547)" This reverts commit 6011673. * chore(migration): out of conflict * chore: more code documentation * chore: recover small improv for uneeded call * chore: detekt * fix: sq migration updated after a really long time =/ * feat: offline backends - handling list-prekeys failed to list (AR-3171) (#1662) * feat: remove unused code, add mapping of proto contentc * feat: expand message target to include users to ignore * feat: resetting intentions on message targets * feat: resetting intentions on message targets * feat: test adjustment for target change * feat: adjusting signatures and simplify message sender mapping * feat: adjusting signatures and simplify message sender mapping * feat: adjusting signatures and simplify message sender mapping * feat: adjusting signatures and simplify message sender mapping * feat: clean code, and fallback for clients targets * feat: ignoring failed recipients mapping for non regular messages * feat: ignoring failed recipients mapping for non regular messages * feat: ignoring failed recipients mapping for non regular messages * feat: adding test coverage * feat: adding test coverage * feat: adding test coverage * chore: tmp for merge * feat: wip, merge sqw * feat: offline backends - users metadata (AR-3124) (#1698) * feat: adjust query to hide 1:1 convos without metadata * feat: adjustment query to consider deleted users logic as it is now * feat: tests for query conversations details * feat: pr comments single quotes * feat(offline-backends): users and conversations without metadata refetch pt1. (AR-3123) (#1736) * feat: adjust query to hide 1:1 convos without metadata * feat: adjustment query to consider deleted users logic as it is now * feat: tests for query conversations details * feat: persistence for getting users out of sync * feat: persistence for getting users out of sync * feat: pr comments single quotes * feat: invok operator * feat: persist failed convos * feat: cleanup * feat: tests cov * feat: tests cov * feat: tests cov * feat: tests cov * feat: refactor, persist users withoutmetadata with dedicated field * feat: refactor, relay on missing metadata field for refetch usres * feat: refactor, relay on missing metadata field for refetch conversations * feat: refactor, relay on missing metadata field for refetch conversations * feat: refactor, relay on missing metadata field for refetch conversations * feat: refactor, fixing tests * chore: add migration tests * feat(offline-backends): users and conversations without metadata refetch pt2. (AR-3123) (#1740) * feat: adjust query to hide 1:1 convos without metadata * feat: adjustment query to consider deleted users logic as it is now * feat: tests for query conversations details * feat: persistence for getting users out of sync * feat: persistence for getting users out of sync * feat: pr comments single quotes * feat: invok operator * feat: persist failed convos * feat: skeleton classes to build upon * feat: skeleton classes to build upon * feat: skeleton classes to build upon * feat: queries and metadata for syncing metadata * feat: provider di * feat: cleanup * feat: cleanup, clock instant * feat: tests cov * feat: tests cov * feat: tests cov * feat: tests cov * feat: refactor, persist users withoutmetadata with dedicated field * feat: refactor, relay on missing metadata field for refetch usres * feat: refactor, relay on missing metadata field for refetch conversations * feat: refactor, relay on missing metadata field for refetch conversations * feat: refactor, relay on missing metadata field for refetch conversations * feat: refactor, fixing tests * chore: add migration tests * chore: ddetekt * chore: new query * chore: test for use case * chore: test cov * chore: test cov * chore: change strategy to run sync after inc * chore: logging * chore: logging * chore: logging ref * fix: db ops * fix: db ops, user persistence fixed * chore: test cov * feat: test coverage * chore: wip for merge * fix: handle edge case error when no sessions * fix: tests * feat: wip merge * feat: wip merge * feat: conversation creation with offline backends (WPB-364) (#1774) * feat: add new response handling create convo v4 * feat: add new response handling create convo v4 test * feat: add new response handling create convo v4 test * feat: add tests cases and persitence of msg for failed to add * feat: add tests cases and persitence of msg for failed to add --------- Co-authored-by: Mohamad Jaara <[email protected]> * chore: preparing for rebase * chore: preparing merge * chore: preparing merge, better naming for func * chore: preparing merge, coverage * chore: preparing merge, coverage --------- Co-authored-by: Mohamad Jaara <[email protected]>

yamilmedina added 11 commits May 2, 2023 22:41

feat: adjust query to hide 1:1 convos without metadata

3c2cf58

feat: adjustment query to consider deleted users logic as it is now

e43eb23

feat: tests for query conversations details

adace80

feat: persistence for getting users out of sync

3a93747

feat: persistence for getting users out of sync

83a6fed

Merge branch 'feat/epic-federation-offline-messages' into feat/epic-f…

58b1840

…ederation-usersmetadata

feat: pr comments single quotes

d15c2d1

Merge branch 'feat/epic-federation-usersmetadata' into feat/federatio…

015624b

…n-usersmetadata-refetch

feat: invok operator

5069394

Merge branch 'feat/epic-federation-offline-messages' into feat/federa…

219c9d3

…tion-usersmetadata-refetch

feat: persist failed convos

86021e0

yamilmedina self-assigned this May 15, 2023

yamilmedina added the WIP work in progress label May 15, 2023

github-actions bot added 🚨 Potential breaking changes type: feature ✨ 👕 size: M labels May 15, 2023

yamilmedina added 4 commits May 16, 2023 14:00

feat: cleanup

41be3f3

feat: tests cov

e17bb9b

feat: tests cov

3ea30dd

feat: tests cov

d9d8c5d

yamilmedina removed the WIP work in progress label May 16, 2023

feat: tests cov

3f8dd00

yamilmedina requested review from vitorhugods, alexandreferris and MohamadJaara May 16, 2023 14:09

yamilmedina changed the title ~~feat(offline-backends): users and conversations without metadata refetch (AR-3123)~~ feat(offline-backends): users and conversations without metadata refetch pt1. (AR-3123) May 16, 2023

alexandreferris reviewed May 16, 2023

View reviewed changes

typfel requested changes May 16, 2023

View reviewed changes

yamilmedina added 2 commits May 17, 2023 11:55

feat: refactor, persist users withoutmetadata with dedicated field

5bd25df

feat: refactor, relay on missing metadata field for refetch usres

30e8e8b

github-actions bot added 👕 size: L and removed 👕 size: M labels May 17, 2023

yamilmedina added 4 commits May 17, 2023 15:06

feat: refactor, relay on missing metadata field for refetch conversat…

6b0fdfe

…ions

feat: refactor, relay on missing metadata field for refetch conversat…

a88437e

…ions

feat: refactor, relay on missing metadata field for refetch conversat…

3770919

…ions

feat: refactor, fixing tests

8b02453

typfel approved these changes May 17, 2023

View reviewed changes

Garzas requested a review from alexandreferris May 18, 2023 09:12

chore: add migration tests

cc2e829

alexandreferris approved these changes May 19, 2023

View reviewed changes

yamilmedina merged commit 53114bd into feat/epic-federation-offline-messages May 19, 2023

yamilmedina deleted the feat/federation-usersmetadata-refetch branch May 19, 2023 09:43

yamilmedina mentioned this pull request Jun 19, 2023

feat(federation): offline backends handling (epic) #1548

Merged

7 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(offline-backends): users and conversations without metadata refetch pt1. (AR-3123) #1736

feat(offline-backends): users and conversations without metadata refetch pt1. (AR-3123) #1736

yamilmedina commented May 15, 2023 •

edited

Loading

github-actions bot commented May 15, 2023 •

edited

Loading

codecov-commenter commented May 15, 2023 •

edited

Loading

alexandreferris left a comment

alexandreferris May 16, 2023

typfel May 16, 2023

yamilmedina May 17, 2023

typfel May 16, 2023

typfel left a comment

feat(offline-backends): users and conversations without metadata refetch pt1. (AR-3123) #1736

feat(offline-backends): users and conversations without metadata refetch pt1. (AR-3123) #1736

Conversation

yamilmedina commented May 15, 2023 • edited Loading

PR Submission Checklist for internal contributors

What's new in this PR?

Issues

Causes (Optional)

Solutions

Testing

Test Coverage (Optional)

Notes (Optional)

PR Post Submission Checklist for internal contributors (Optional)

PR Post Merge Checklist for internal contributors

References

github-actions bot commented May 15, 2023 • edited Loading

Unit Test Results

codecov-commenter commented May 15, 2023 • edited Loading

Codecov Report

alexandreferris left a comment

Choose a reason for hiding this comment

alexandreferris May 16, 2023

Choose a reason for hiding this comment

typfel May 16, 2023

Choose a reason for hiding this comment

yamilmedina May 17, 2023

Choose a reason for hiding this comment

typfel May 16, 2023

Choose a reason for hiding this comment

typfel left a comment

Choose a reason for hiding this comment

yamilmedina commented May 15, 2023 •

edited

Loading

github-actions bot commented May 15, 2023 •

edited

Loading

codecov-commenter commented May 15, 2023 •

edited

Loading