Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(e2ei): remove E2EI shield and buttons if it's disabled on your team (WPB-6520) #2489

Merged
merged 1 commit into from
Feb 13, 2024

Conversation

mchenani
Copy link
Contributor


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

When E2EI is disabled on the user's team, all the info related to e2ei must be hidden.

Issues

Wasn't covered.


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

Copy link
Contributor

github-actions bot commented Feb 13, 2024

Test Results

2 788 tests   2 659 ✔️  27s ⏱️
   483 suites     129 💤
   483 files           0

Results for commit 4378cb0.

♻️ This comment has been updated with latest results.

@mchenani mchenani merged commit 6be08c5 into release/candidate Feb 13, 2024
18 checks passed
@mchenani mchenani deleted the release/fix/hide-e2ei-info-if-disabled branch February 13, 2024 10:24
github-merge-queue bot pushed a commit that referenced this pull request Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants