-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(e2ei): remove E2EI shield and buttons if it's disabled on your team (WPB-6520) #2695
fix(e2ei): remove E2EI shield and buttons if it's disabled on your team (WPB-6520) #2695
Conversation
Test Results12 tests 12 ✅ 0s ⏱️ Results for commit b824857. ♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Just maybe one log line that can/should be removed?
It would be great to have snapshot testing for this 😅
Maybe sometime in the future :D
app/src/main/kotlin/com/wire/android/ui/settings/devices/DeviceDetailsScreen.kt
Outdated
Show resolved
Hide resolved
app/src/main/kotlin/com/wire/android/ui/settings/devices/DeviceDetailsScreen.kt
Outdated
Show resolved
Hide resolved
Build 3089 failed. |
APKs built during tests are available here. Scroll down to Artifacts! |
Build 3095 succeeded. The build produced the following APK's: |
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
When E2EI is disabled on the user's team, all the info related to e2ei must be hidden.
Needs releases with:
Testing
Login to the user and if e2ei is disabled, shields and the get certificate on the current device screen shouldn't be visible, and if enable e2ei you should see the data.
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.