Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(e2ei): remove E2EI shield and buttons if it's disabled on your team (WPB-6520) #2695

Merged
merged 6 commits into from
Feb 13, 2024

Conversation

mchenani
Copy link
Contributor

@mchenani mchenani commented Feb 13, 2024

BugWPB-6520 [Android] Don't show the e2ei get certificate button if e2ei is disabled


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

When E2EI is disabled on the user's team, all the info related to e2ei must be hidden.

Needs releases with:

Testing

Login to the user and if e2ei is disabled, shields and the get certificate on the current device screen shouldn't be visible, and if enable e2ei you should see the data.


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

Copy link
Contributor

github-actions bot commented Feb 13, 2024

Test Results

12 tests   12 ✅  0s ⏱️
 3 suites   0 💤
 3 files     0 ❌

Results for commit b824857.

♻️ This comment has been updated with latest results.

@mchenani mchenani enabled auto-merge (squash) February 13, 2024 10:16
Copy link
Member

@vitorhugods vitorhugods left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Just maybe one log line that can/should be removed?

It would be great to have snapshot testing for this 😅
Maybe sometime in the future :D

@mchenani mchenani requested a review from ohassine February 13, 2024 10:26
@AndroidBob
Copy link
Collaborator

Build 3089 failed.

@mchenani mchenani merged commit ea33f80 into release/candidate Feb 13, 2024
11 of 12 checks passed
@mchenani mchenani deleted the release/fix/hide-e2ei-info-if-disabled branch February 13, 2024 12:57
Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 3095 succeeded.

The build produced the following APK's:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants