Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove You/null from self deleting notification (WPB-3553) #2096

Merged
merged 2 commits into from
Aug 14, 2023
Merged

fix: remove You/null from self deleting notification (WPB-3553) #2096

merged 2 commits into from
Aug 14, 2023

Conversation

alexandreferris
Copy link
Contributor

PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³

  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

When receiving a self deleting message (either group or 1:1), it would be showing You or null as the senders name instead of Someone

Solutions

When message is self deleting, add Person/sender as Someone as per in the mocks.

Testing

How to Test

  • Receive self deleting message in group and 1:1
  • Verify sender name is Someone and not You or null

Attachments (Optional)

Wire 2023-08-14 at 2_39 PM

@alexandreferris alexandreferris self-assigned this Aug 14, 2023
@alexandreferris alexandreferris requested review from a team, gongracr, yamilmedina, mchenani, Garzas and saleniuk and removed request for a team August 14, 2023 13:24
@github-actions
Copy link
Contributor

Test Results

542 tests   541 ✔️  24s ⏱️
  77 suites      1 💤
  77 files        0 ❌

Results for commit 3125df1.

@github-actions
Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 1078 succeeded.

The build produced the following APK's:

@alexandreferris alexandreferris enabled auto-merge (squash) August 14, 2023 13:50
@alexandreferris alexandreferris merged commit a6a1f6a into release/candidate Aug 14, 2023
@alexandreferris alexandreferris deleted the fix/self_deleting_notification_user_you branch August 14, 2023 14:56
github-actions bot pushed a commit that referenced this pull request Aug 14, 2023
@alexandreferris @github-actions
fix: remove You/null from self deleting notification (WPB-3553) (#2096)
280844e
@github-actions github-actions bot mentioned this pull request Aug 14, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yamilmedina yamilmedina yamilmedina approved these changes

@saleniuk saleniuk saleniuk approved these changes

@gongracr gongracr Awaiting requested review from gongracr gongracr was automatically assigned from wireapp/android

@mchenani mchenani Awaiting requested review from mchenani mchenani was automatically assigned from wireapp/android

@Garzas Garzas Awaiting requested review from Garzas Garzas was automatically assigned from wireapp/android

Assignees

@alexandreferris alexandreferris

Labels
size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alexandreferris @AndroidBob @yamilmedina @saleniuk