Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove You/null from self deleting notification (WPB-3553) #2098

Merged
merged 2 commits into from
Aug 14, 2023

Conversation

github-actions[bot]
Copy link
Contributor

Cherry pick from the original PR:


⚠️ Conflicts during cherry-pick:


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

When receiving a self deleting message (either group or 1:1), it would be showing You or null as the senders name instead of Someone

Solutions

When message is self deleting, add Person/sender as Someone as per in the mocks.

Testing

How to Test

  • Receive self deleting message in group and 1:1
  • Verify sender name is Someone and not You or null

Attachments (Optional)

Wire 2023-08-14 at 2_39 PM

@github-actions github-actions bot added the cherry-pick PR is cherry-picking changes from another banch label Aug 14, 2023
@alexandreferris alexandreferris requested review from a team, typfel, alexandreferris, borichellow, trOnk12 and ohassine and removed request for a team August 14, 2023 15:05
@codecov
Copy link

codecov bot commented Aug 14, 2023

Codecov Report

Merging #2098 (cd33298) into develop (2000815) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@              Coverage Diff              @@
##             develop    #2098      +/-   ##
=============================================
- Coverage      39.63%   39.63%   -0.01%     
  Complexity       939      939              
=============================================
  Files            305      305              
  Lines          11262    11263       +1     
  Branches        1506     1506              
=============================================
  Hits            4464     4464              
- Misses          6369     6370       +1     
  Partials         429      429              
Files Changed Coverage Δ
...android/notification/MessageNotificationManager.kt 0.00% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2000815...cd33298. Read the comment docs.

@github-actions
Copy link
Contributor Author

Test Results

537 tests  ±0   536 ✔️ ±0   7m 29s ⏱️ + 1m 48s
  79 suites ±0       1 💤 ±0 
  79 files   ±0       0 ±0 

Results for commit cd33298. ± Comparison against base commit 2000815.

@github-actions
Copy link
Contributor Author

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 1083 succeeded.

The build produced the following APK's:

@tmspzz tmspzz added this pull request to the merge queue Aug 14, 2023
Merged via the queue into develop with commit 98db6d7 Aug 14, 2023
@tmspzz tmspzz deleted the fix/self_deleting_notification_user_you-cherry-pick branch August 14, 2023 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick PR is cherry-picking changes from another banch size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants