Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: empty conversation list on import media [WPB-10483] #3400

Merged
merged 2 commits into from
Aug 28, 2024

Conversation

Garzas
Copy link
Contributor

@Garzas Garzas commented Aug 28, 2024

BugWPB-10483 [Android] empty conversation list when sharing image using sharing extention


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

  • updating conversation list was not executed on main dispatcher
  • updating same state from different observers may cause race condition

Causes (Optional)

Random empty conversation list

Solutions

  • Introduce separate state for avatar asset
  • update conversation list on main dispatcher

@Garzas Garzas self-assigned this Aug 28, 2024
@echoes-hq echoes-hq bot added the echoes: unplanned Any work item that isn’t part of the product or technical roadmap. label Aug 28, 2024
Copy link

Please retry analysis of this Pull-Request directly on SonarCloud

@codecov-commenter
Copy link

codecov-commenter commented Aug 28, 2024

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 44.75%. Comparing base (72616dc) to head (cfdc183).
Report is 321 commits behind head on release/candidate.

Files with missing lines Patch % Lines
...id/ui/sharing/ImportMediaAuthenticatedViewModel.kt 0.00% 6 Missing ⚠️
Additional details and impacted files
@@                Coverage Diff                 @@
##           release/candidate    #3400   +/-   ##
==================================================
  Coverage              44.75%   44.75%           
==================================================
  Files                    456      456           
  Lines                  15404    15404           
  Branches                2574     2574           
==================================================
  Hits                    6894     6894           
  Misses                  7783     7783           
  Partials                 727      727           
Files with missing lines Coverage Δ
...id/ui/sharing/ImportMediaAuthenticatedViewModel.kt 0.00% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 72616dc...cfdc183. Read the comment docs.

Copy link
Contributor

Built wire-android-staging-compat-pr-3400.apk is available for download

@MohamadJaara MohamadJaara added this pull request to the merge queue Aug 28, 2024
Merged via the queue into release/candidate with commit a62d4df Aug 28, 2024
13 checks passed
@MohamadJaara MohamadJaara deleted the fix/import-media-empty-conversations branch August 28, 2024 14:56
@echoes-hq echoes-hq bot added echoes: product-roadmap/bug Work contributing to resolve a bug not critical enough to have raised an incident. and removed echoes: unplanned Any work item that isn’t part of the product or technical roadmap. labels Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: product-roadmap/bug Work contributing to resolve a bug not critical enough to have raised an incident. size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants